Update to use new props/targets plus cleanup. #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1451 +/- ##
==========================================
- Coverage 83.69% 83.66% -0.03%
==========================================
Files 734 736 +2
Lines 31995 32012 +17
Branches 3605 3609 +4
==========================================
+ Hits 26777 26782 +5
- Misses 4505 4516 +11
- Partials 713 714 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
brianpopow
approved these changes
Dec 2, 2020
JimBobSquarePants
added a commit
that referenced
this pull request
Mar 13, 2021
Update to use new props/targets plus cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Vastly simplifies the solution by reusing props/targets defined in our infrastructure. I've also done some tests cleanup to match rules and added missing images to the solution plus replaced the EXIF standard PDF broken by old gitattributes.