Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Updated Bulgarian translations #21932

Merged
merged 8 commits into from
Jan 28, 2025
Merged

🌐 Updated Bulgarian translations #21932

merged 8 commits into from
Jan 28, 2025

Conversation

yovko
Copy link
Contributor

@yovko yovko commented Dec 19, 2024

  • Some improvements to the previously translated strings
  • Translations of newly introduced strings

Summary by CodeRabbit

  • Localization
    • Updated Bulgarian translations for comments, newsletter, portal, search, and signup form.
    • Added missing translations for phrases like "Hidden for members" and "Load more".
    • Refined wording for search messages, including "No matches found" and "Show more results".
    • Enhanced clarity of user interface messages in Bulgarian, such as "Comment preferences updated" and "Email preferences updated".
    • Modified tone of the signup message to be more emphatic with an exclamation mark.

@yovko yovko changed the title 🇧🇬 Bulgarian translation - updates (Dec 2024) 🌐 Added and corrected strings in the Bulgarian (bg) i18n locale files. [🇧🇬 Dec 2024] Dec 19, 2024
@yovko yovko changed the title 🌐 Added and corrected strings in the Bulgarian (bg) i18n locale files. [🇧🇬 Dec 2024] 🌐 Added and corrected strings in the Bulgarian (bg) i18n locale files [Dec 2024] Dec 19, 2024
@yovko yovko changed the title 🌐 Added and corrected strings in the Bulgarian (bg) i18n locale files [Dec 2024] 🌐 Added new and corrected some strings in the Bulgarian (bg) i18n locale files [Dec 2024] Jan 6, 2025
@yovko yovko changed the title 🌐 Added new and corrected some strings in the Bulgarian (bg) i18n locale files [Dec 2024] 🌐 Updated Bulgarian translations Jan 14, 2025
Copy link
Contributor

coderabbitai bot commented Jan 20, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • ghost/i18n/locales/bg/comments.json is excluded by !ghost/i18n/locales/**
  • ghost/i18n/locales/bg/portal.json is excluded by !ghost/i18n/locales/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This pull request focuses on updating Bulgarian translations across several locale files in the Ghost project. The changes include adding missing translations, refining existing translations, and making minor linguistic adjustments to improve clarity and user experience. The modifications span multiple JSON files related to comments, newsletters, portal, search, and signup forms, ensuring more comprehensive and accurate Bulgarian language support.

Changes

File Changes
ghost/i18n/locales/bg/comments.json - Added "Скрит за абонати" for "Hidden for members"
- Added "Още ({{amount}})" for "Load more ({{amount}})"
- Added "премахнат" for "removed"
ghost/i18n/locales/bg/newsletter.json - Updated "complimentary" translation from "подарен" to "подарък"
ghost/i18n/locales/bg/portal.json - Added translations for messages about comment preferences, payment sessions, email settings, and recommendations
ghost/i18n/locales/bg/search.json - Changed "No matches found" to "Няма намерени съвпадения"
- Updated "Show more results" to "Покажи още резултати"
ghost/i18n/locales/bg/signup-form.json - Added exclamation mark to "Now check your email!" translation

Possibly related PRs

  • ActivityPub fixes and improvements #22020: The changes in the main PR regarding translations in user interface elements are related to the updates in the "ActivityPub fixes and improvements" PR, specifically the modifications to the terminology used in the UI, such as the "Show all" button, which aligns with the localization efforts in the main PR.

Poem

🐰 Bulgarian words, crisp and bright,
Translations dancing with delight!
From empty strings to phrases clear,
Our language grows without a fear.
CodeRabbit's touch makes meaning shine ✨


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ca066c and 6f9f6c6.

📒 Files selected for processing (5)
  • ghost/i18n/locales/bg/comments.json (1 hunks)
  • ghost/i18n/locales/bg/newsletter.json (1 hunks)
  • ghost/i18n/locales/bg/portal.json (4 hunks)
  • ghost/i18n/locales/bg/search.json (1 hunks)
  • ghost/i18n/locales/bg/signup-form.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • ghost/i18n/locales/bg/signup-form.json
🔇 Additional comments (3)
ghost/i18n/locales/bg/search.json (1)

4-4: Excellent translation improvements!

The changes enhance the Bulgarian translations by:

  1. Using "съвпадения" (matches) instead of "резултати" (results) which is more accurate in search context
  2. Using the imperative form "Покажи" which makes the UI more engaging

Also applies to: 7-7

ghost/i18n/locales/bg/comments.json (1)

32-32: Well-implemented translations!

The new translations are concise, accurate, and maintain consistency with existing terminology. The use of "Още" for "Load more" is particularly good as it keeps the UI clean and intuitive.

Also applies to: 38-38, 46-46

ghost/i18n/locales/bg/portal.json (1)

40-40: Great work on the portal translations!

The translations are well-crafted:

  1. Consistent terminology across notification messages
  2. Clear and informative error messages
  3. Natural-sounding Bulgarian that maintains professionalism

Also applies to: 49-49, 60-60, 62-62, 142-142

@yovko
Copy link
Contributor Author

yovko commented Jan 27, 2025

Hi @ErisDS

what else do I need to do to have this PR merged (after already a month and a half of waiting)?

@cathysarisky
Copy link
Contributor

Sorry for the wait @yovko . I review translations as an unpaid contribution to Ghost, and I've been swamped with paying work and trying to catch up after the holidays. I'm working on this now.

Minor change (improvement)
@yovko yovko requested a review from cathysarisky January 28, 2025 16:59
@9larsons 9larsons merged commit 4946c91 into TryGhost:main Jan 28, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants