🌐 Updated German translations #22241
Conversation
WalkthroughThis pull request updates German localization files by providing complete translations for various interface strings in Ghost. The changes span three JSON files: Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| "trialing": "Probe-", | ||
| "Unsubscribe": "Abbestellen", | ||
| "View in browser": "Im Browser ansehen", | ||
| "You are receiving this because you are a <strong>%%{status}%% subscriber</strong> to {site}.": "Du erhälst diese Nachricht weil du <strong>%%{status}%% Mitglied</strong> von {site} bist.", |
There was a problem hiding this comment.
AI says this should be erhältst ? Correct?
There was a problem hiding this comment.
Yes, seems to be a typo "erhältst" is correct.
| "Name": "Name", | ||
| "paid": "zahlendes", | ||
| "Subscription details": "Abo Details", | ||
| "trialing": "Probe-", |
There was a problem hiding this comment.
The present set of translation strings for free/paid/trialing/complimentary get substituted in for %%status%%. That's going to result in a space after the hyphen for trialing. Adequate, or do you want to pull the word Mitglied into the free/trialing/etc phrases and remove it from the full-sentence translation?
There was a problem hiding this comment.
You are right, that is suboptimal. The issue is that "trialing subscriber" would be translated as a compound noun in German. I could not come up with an adjective that would fit as a separate word.
Ideally, instead of inserting an adjective as placeholder, it would be changed to "free_subscriber", "paid_subscriber", etc, would should also work with other languages.
Here's an alternative, though hacky solution:
"complimentary": "kostenfreies Mitglied",
"free": "kostenfreies Mitglied",
"paid": "zahlendes Mitglied",
"trialing": "Probemitglied",
"You are receiving this because you are a <strong>%%{status}%% subscriber</strong> to {site}.": "Du erhälst diese Nachricht weil du <strong>%%{status}%%</strong> von {site} bist.",But I worried that that's not future proof, as "free" etc would be used in other contexts.
There was a problem hiding this comment.
I changed it to "Probeabo Mitglied" which still isn't perfect, but should look less weird than "Probe- Mitglied".
Added missing german translations.
I couldn't get unit tests and the linter running, but this shouldn't be related to the PR itself.