-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update comments.json #22237
Update comments.json #22237
Conversation
added missing translations phrases for german (du)
WalkthroughThis change updates a German localization file for comments. The modifications include adding German translations for the "Are you sure?" and "Sort by" keys, which were previously empty. Additionally, several keys—namely "Deleted", "Hidden for members", "Load more ({{amount}})", "Once deleted, this comment can’t be recovered.", "removed", and "Replied to"—have been removed from the localization file, indicating these phrases will no longer be available in the German interface. Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
ghost/i18n/locales/de/comments.json (1)
20-22
: Review Unused or Removed Translation KeysThe keys "Deleted", "Deleting", "Hidden for members", "Load more ({{amount}})", "Once deleted, this comment can’t be recovered.", "removed", and "Replied to" appear with empty values. According to the PR summary, these keys were intended to be removed. To avoid any potential confusion or accidental usage in the interface, please consider either removing them entirely from the JSON file or adding inline comments to explain why they remain as empty strings.
Also applies to: 32-32, 38-38, 43-43, 46-47
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
ghost/i18n/locales/de/comments.json
(2 hunks)
🔇 Additional comments (2)
ghost/i18n/locales/de/comments.json (2)
13-13
: Appropriate German Translation for "Are you sure?"This update enriches the localization by providing a clear, informal translation ("Bist du sicher?") that aligns well with our German (du-form) guidelines for direct address.
63-63
: Updated Translation for "Sort by"The new translation ("Sortieren nach") correctly reflects the informal tone consistent with our German localization objectives.
Thanks for the contribution @noezdev! In this case I'm going to close the PR in favour of this more complete German translation. If you have a moment to review that and provide any recommendations on the provided translations that would be greatly appreciated. |
We got two PRs for this file in the same day! Because the other PR covers more strings, I'm going to recommend we put the focus there, and close this one. Would you please have a look over this PR instead? #22241 . Any suggestions you can make would be very much appreciated! |
added missing translations phrases for german (du)