Move setup instructions to ur_client_library #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the assembled documentation this wasn't working properly otherwise.
3 tasks
urfeex
force-pushed
the
doc_robot_setup
branch
from
69cc8f9 to
8eb1f2d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #248 +/- ##
==========================================
+ Coverage 71.71% 73.03% +1.31%
==========================================
Files 71 75 +4
Lines 2786 2896 +110
Branches 353 360 +7
==========================================
+ Hits 1998 2115 +117
+ Misses 596 594 -2
+ Partials 192 187 -5 ☔ View full report in Codecov by Sentry. |
As the robot setup instructions are independent whether ROS, ROS 2 or a custom application is using the client library, documentation for that should also go to the client library.
urfeex
force-pushed
the
doc_robot_setup
branch
from
8eb1f2d to
d6944a1
Compare
urrsk
reviewed
Jan 21, 2025
|
Suggest updating the PolyscopeX service screen picture to a screenshot like this one where only Primary, secondary and RTDE is enabled: |
|
Suggest using tabs for the installation on CB3, E-series and PolyscopeX instead of different pages |
urrsk
reviewed
Jan 23, 2025
urrsk
reviewed
Jan 23, 2025
Co-authored-by: Rune Søe-Knudsen <[email protected]>
urrsk
reviewed
Jan 23, 2025
urrsk
reviewed
Jan 23, 2025
Co-authored-by: Rune Søe-Knudsen <[email protected]>
urrsk
reviewed
Jan 23, 2025
urrsk
reviewed
Jan 23, 2025
urrsk
reviewed
Jan 23, 2025
urrsk
reviewed
Jan 23, 2025
urrsk
reviewed
Jan 23, 2025
| Script startup | ||
| -------------- | ||
|
|
||
| All of the above is put together in a script in the ``ur_client_library`` package. |
There was a problem hiding this comment.
Suggested change
| All of the above is put together in a script in the ``ur_client_library`` package. | |
| All of the above is put together in a script in the ``ur_client_library`` ROS package. |
There was a problem hiding this comment.
Isn't that a bit misleading? It's part of the ur_client_library. Yes, it gets installed in the ROS packages, but they are merely distributions of this repo. I would consider the code in this repo a package also independent of ROS.
|
urrsk
requested changes
Jan 23, 2025
Co-authored-by: Rune Søe-Knudsen <[email protected]>
How about 55cdf01? |
urrsk
requested changes
Jan 27, 2025
Co-authored-by: Rune Søe-Knudsen <[email protected]>
urrsk
requested changes
Jan 27, 2025
Co-authored-by: Rune Søe-Knudsen <[email protected]>
urrsk
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #240 we want to move more common setup instructions to the client library. It's documentation is pulled into https://github.com/UniversalRobots/Universal_Robots_ROS_Documentation anyway, so it will be available in the ROS documentation, anyway.
This is currently a draft, as there will be accompanying PRs in the ROS 2 driver and documentation repos.
Closing #240