Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the pattern search API, use the client locale when querying #244

Closed
3 of 4 tasks
iandunn opened this issue Jun 29, 2021 · 4 comments
Closed
3 of 4 tasks

In the pattern search API, use the client locale when querying #244

iandunn opened this issue Jun 29, 2021 · 4 comments
Assignees
Labels
[Component] Pattern Directory API The pattern API on WordPress.org, and/or the CPT endpoint [Component] Pattern Directory The backend of the pattern directory: submission, management, etc [Type] Enhancement New feature or request
Milestone

Comments

@iandunn
Copy link
Member

iandunn commented Jun 29, 2021

See #223 / #224

Pulls locale from post meta, see #229

Pre-launch

Post-launch

@iandunn iandunn self-assigned this Jun 29, 2021
@iandunn iandunn added this to the Initial Launch milestone Jun 29, 2021
@iandunn iandunn added [Component] Pattern Directory API The pattern API on WordPress.org, and/or the CPT endpoint [Component] Pattern Directory The backend of the pattern directory: submission, management, etc [Type] Enhancement New feature or request and removed [Type] Tracking Issue labels Jun 30, 2021
iandunn added a commit that referenced this issue Jun 30, 2021
Meta queries are slow, so running them through will be much faster, and may be necessary for scaling.

A future commit will setup ES for this (probably after #28), this commit just gets the data there so it's possible to test.

See #244
bazza pushed a commit to WordPress/wordpress.org that referenced this issue Jun 30, 2021
@dd32
Copy link
Member

dd32 commented Jul 1, 2021

d75ca62 causes a bit of a shortcoming, in that patterns without a translation become inaccessible.

Instead, I think we need to prioritise translated patterns but not skip not-localised.

@iandunn
Copy link
Member Author

iandunn commented Jul 8, 2021

Do you mean that requests for es_MX patterns won't include en_US "parent" patterns that don't have a es_MX "child/translated" variant/fork yet?

That seems good enough for launch, since all the "core/featured" patterns will be translated.

We might want to wait until after #28 too, since ES might make that prioritization easier. On the other hand, Learn already does that kind of sorting w/ WP_Query, so we could just copy that 🤔

@iandunn
Copy link
Member Author

iandunn commented Jul 13, 2021

Removing this from the milestone since the pre-launch tasks are done.

@ryelle
Copy link
Contributor

ryelle commented Dec 1, 2021

It looks like all the linked PRs have been merged, so I'm going to close this issue.

@ryelle ryelle closed this as completed Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Pattern Directory API The pattern API on WordPress.org, and/or the CPT endpoint [Component] Pattern Directory The backend of the pattern directory: submission, management, etc [Type] Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants