Prioritise results by requested locale, but return Locale and default (en_US) patterns. #307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Pattern directory limits the results to the given locale, this is not ideal in all situations.
Consider:
foo_bar
locale is admittedly not used on any sites, but it's not uncommon to see API requests with it set toen
ores
which are equally invalidWP_Locale
values.This PR changes the logic from only returning results in the matching locale, to returning in both the local and in en_US, with the localised results first.
No attempt at deduplication is done here, both the Translated and english results would be returned.
This also has the benefit that searching an English phrase would result in matching an english pattern, and not just returning an empty data set if it's not included in the locale translated patterns. Searching for a German phrase on an English or French site would however not return a matching German pattern.
See #244
Screenshots
How to test the changes in this Pull Request: