Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

[FEATURE] STDIN Implementation #97

Merged
merged 34 commits into from
May 20, 2020
Merged

[FEATURE] STDIN Implementation #97

merged 34 commits into from
May 20, 2020

Conversation

GuillaumeFalourd
Copy link
Contributor

- What I did

- How I did it

  • Create a flag STDIN that would be false or true according to the command line.
  • Add a JsonDecoder method (variables will be send as json with ECHO, see examples below)
  • Update all core commands with inputs to work with STDIN
  • Update runner method to check config.json file from formulas before executing them with STDIN.

- How to verify it

  • By executing a STDIN command to execute a formula locally :

echo "{\"name\":\"Dennis Ritchie\",\"coffee_type\":\"espresso\",\"delivery\":\"true\"}" | ./dist/mac/single/rit scaffold generate coffee-go --stdin

OR

echo "{\"treePath\":\"https://commons-repo.ritchiecli.io/tree/tree.json\",\"name\":\"commons-repo\",\"priority\":1}" | ./dist/mac/single/rit add repo --stdin

- Description for the changelog

  • STDIN Implementation (core commands + formulas)

@GuillaumeFalourd GuillaumeFalourd added ✨ feature Suggest a new feature or enhancement to the Ritchie project 🔨 improvement Improvement in features labels May 18, 2020
@GuillaumeFalourd GuillaumeFalourd changed the title [FEATURE] Allowing STDIN [FEATURE] STDIN Implementation May 18, 2020
@GuillaumeFalourd GuillaumeFalourd linked an issue May 18, 2020 that may be closed by this pull request
@codecov-io
Copy link

codecov-io commented May 18, 2020

Codecov Report

Merging #97 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   41.94%   41.94%           
=======================================
  Files          58       58           
  Lines        2360     2360           
=======================================
  Hits          990      990           
  Misses       1199     1199           
  Partials      171      171           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5806193...5806193. Read the comment docs.

@marcosgmgm marcosgmgm merged commit 06d72d9 into ZupIT:master May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔨 improvement Improvement in features ✨ feature Suggest a new feature or enhancement to the Ritchie project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] STDIN Implementation on Ritchie-CLI
4 participants