Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

[REFACTOR] Formula/creator #98

Closed
wants to merge 3 commits into from
Closed

[REFACTOR] Formula/creator #98

wants to merge 3 commits into from

Conversation

victor-schumacher
Copy link
Contributor

- What I did
A general refactor at creator.go and and templates.

- How I did it

Changing create functions to be more generic;
Segregated the creation of packge.json, so in future, it can be used by another languages like typescript;
Removed some unused string operations;
Removed the "Template" before each tpl_lang.go variable, since it's inside a tpl file.

- How to verify it
It's a refactor pull request, so you can just make sure everything is ok.

- Description for the changelog
general refactor at creator.go and and templates.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #98 into master will decrease coverage by 1.13%.
The diff coverage is 96.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   44.34%   43.20%   -1.14%     
==========================================
  Files          56       56              
  Lines        2156     2104      -52     
==========================================
- Hits          956      909      -47     
+ Misses       1040     1035       -5     
  Partials      160      160              
Impacted Files Coverage Δ
pkg/formula/creator.go 71.09% <96.55%> (-2.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85cc3a5...0da7866. Read the comment docs.

@victor-schumacher
Copy link
Contributor Author

@GuillaumeFalourd GuillaumeFalourd added the 🔨 improvement Improvement in features label May 19, 2020
@GuillaumeFalourd
Copy link
Contributor

The correction of the functional-test that broke the circle-ci build has been implemented in this PR : #97

@GuillaumeFalourd GuillaumeFalourd changed the title Refactor/creator [REFACTOR] Formula/creator May 19, 2020
@marcosgmgm marcosgmgm closed this May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔨 improvement Improvement in features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants