-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(options): add new options to avoid stale based on comments #508
Conversation
09d1712
to
07423be
Compare
I'm kind of stuck with the issue it caused. |
@C0ZEN what's the issue? |
It makes sense to have this feature but the current implementation is actually helping the case where an issue is marked as stale then still in the same workflow process it for closing process. In such case the freshly staled issue update date is set as today and with the current implementation provided in this PR it will consider the issue as no longer stale if a comment was added. If the new option to install when commented is disabled there is no problem |
473ca4b
to
4755004
Compare
Helping to close actions#441, actions#470, actions#435? Closes actions#390 due to no activity BREAKING CHANGES: the options related to remove-stale-when-updated will only check the updates, not the comment. It is only impactint the configurations using the value at false
a8ac4e8
to
a8f503a
Compare
The last added test is actually failing because just after staling, the workflow continue and then consider the issue as stale but to unstale due to |
actually it's to be identical to GitHub and will also avoid an issue
I close it because I just don't understand the whole workflow. |
Changes
remove-stale-when-updated
will be reduced, resulting in a breaking change (@luketomlinson for the release notes!) when using the option atfalse
Context
Helping to close (maybe) #441, #470, #435?
Closes #390 due to no activity