-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep for v4 #510
Prep for v4 #510
Conversation
@C0ZEN FYI ☝️ |
@C0ZEN The |
@luketomlinson at least on my side I think my PR titles are good but yeah, every tool is about having a strict syntax. |
@luketomlinson is it WIP? |
Oh that's probably because of my commits. I didn't find any comments on the commit messages, which is why I didn't pay attention. Would it make sense to write a comment in the contributing file how to name the pull requests? |
@flaxel dunno. |
An action such as action-semantic-pull-request could also be used if it is not intended to be an app. |
@luketomlinson When do you think you can release the new version? |
@luketomlinson I don't think so because actually, I still didn't find the way to implement it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luketomlinson dunno if you are waiting an approval, so I made a final review and voilà ;)
CHANGELOG.md
Outdated
# Changelog | ||
Starting in version 4.0.0 we will maintain a changelog | ||
|
||
## [4.0.0](https://github.com/actions/stale/compare/v3.0.19...v4.0.0) (2021-06-18) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## [4.0.0](https://github.com/actions/stale/compare/v3.0.19...v4.0.0) (2021-06-18) | |
## [4.0.0](https://github.com/actions/stale/compare/v3.0.19...v4.0.0) (2021-06-27) |
@luketomlinson any news? |
Co-authored-by: Geoffrey Testelin <[email protected]>
Co-authored-by: Geoffrey Testelin <[email protected]>
Co-authored-by: Geoffrey Testelin <[email protected]>
Co-authored-by: Geoffrey Testelin <[email protected]>
Co-authored-by: Geoffrey Testelin <[email protected]>
0f9cdf0
to
50125be
Compare
Changes