Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discussion models to the backend #619

Closed
2 tasks done
andrewtavis opened this issue Dec 24, 2023 · 14 comments
Closed
2 tasks done

Add discussion models to the backend #619

andrewtavis opened this issue Dec 24, 2023 · 14 comments
Assignees
Labels
- Code Night 🌙 - Worked on during an activist Code Night 🌙 feature New feature or request help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Dec 24, 2023

Terms

Description

This issue would go through and add in the discussion models to the backend as we'll be needing them for eventual organization application discussions and those for event pages and organization blogs. The schemas can be found in the designs on Figma, with the discussion and discussion_entry logic being needed. These changes should be made in content directory of the backend 😊

Contribution

Happy to discuss and support as needed! Note that @ahmedy00 has expressed interest in this 🙂

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed labels Dec 24, 2023
@andrewtavis
Copy link
Member Author

andrewtavis commented Dec 24, 2023

Ping @ahmedy00: can you write in here so I can assign?

Also ping @to-sta: I figure adding the logic for these two tables is ok as again we'll need these before the task ones. I'll also make an issue for the vote tables, and from there the last things are tags and movements (at the bottom), which I think we can hold off on for now. I've also marked the tag tables in the schemas as not implemented 😊

@ahmedy00
Copy link
Contributor

@andrewtavis, thank you, I'd be happy if you assign it to me.

@andrewtavis andrewtavis moved this from Todo to In Progress in activist Board Dec 24, 2023
@andrewtavis
Copy link
Member Author

Happy to assign, @ahmedy00! Let us know if there's anything we can do to help 😊

@andrewtavis
Copy link
Member Author

@to-sta, I'm realizing that we also have a similar problem for discussion votes that we have for flags. In the schemas it's just an int, but we need this to be linked to the user who did it so we have a unique association. How do do this 🤔

I don't think we need a vote table?? @to-sta, @ahmedy00, can you two think of anything else that we're voting for? Nothing comes up in the search of votes for the schema except for the actual tables for vote entities in the top right. We also have the organization application, but then I think that it having its own table would be fine. Maybe we should combine with vote entities if there are other things though.

@andrewtavis
Copy link
Member Author

For now I'll make a discussion_upvote table that we can also include in this, but please let me know what else we could consider!

@andrewtavis
Copy link
Member Author

I made discussion_upvote that has a column for the discussion_id, user_id and also entry_id for a comment itself that can be NULL. Maybe we can also do NULL for the discussion_id as we don't need to explicitly always associate a discussion entry with its discussion, but then I'm not sure.

Just to go through this a bit more: organizations and groups would have multiple discussions, and events would have a single discussion. Within each there would be discussion entries :)

@andrewtavis
Copy link
Member Author

andrewtavis commented Dec 25, 2023

Just synced with @therealhoppi on this and edited the table after our discussion/decisions. We were thinking that upvoting the first entry in the discussion is equivalent to upvoting the discussion itself, so we don't need two different columns for discussion_id and entry_id. It's now just entry_id 😊

@IsaacDMz
Copy link
Contributor

@andrewtavis can i work on this task?

@andrewtavis andrewtavis assigned IsaacDMz and unassigned ahmedy00 Jan 10, 2024
@andrewtavis
Copy link
Member Author

Thanks for jumping in and working on this, @IsaacDMz! Let us know if there's anything we can do to support :)

@anthonyshibitov
Copy link
Contributor

heyo, is this open?

@andrewtavis
Copy link
Member Author

Hey @anthonyshibitov 👋 Let's check in with @IsaacDMz first, but you'd be welcome to pick this up :)

@IsaacDMz
Copy link
Contributor

Hi guys, i has some problems to build the project in my new PC, the virtualization is not working and docker is not running, I'm trying but I can't solve it. I don't know when i will solve this.

So, you can pass it on to him, and when I manage to solve these problems I will return to work in other tasks.

@andrewtavis
Copy link
Member Author

Thanks for the update, @IsaacDMz! Hope it all works out soon and we can get you on the next issue ASAP :)

@anthonyshibitov, assigning to you, and let us know if there's anything we can do to help 😊

@andrewtavis andrewtavis added the - Code Night 🌙 - Worked on during an activist Code Night 🌙 label Jan 27, 2024
anthonyshibitov added a commit to anthonyshibitov/activist that referenced this issue Feb 5, 2024
movement_id and vote_id are currently not implemented, denoted
by comments.

Issue activist-org#619
andrewtavis added a commit to anthonyshibitov/activist that referenced this issue Feb 18, 2024
@andrewtavis
Copy link
Member Author

Closed by #688 🥳 Thanks for the continued contributions, @anthonyshibitov! We'll be sure to get them in a bit quicker the next time around. Has just been hectic :)

Hope to see you at a sync soon! Next one's the 20th 😊

@github-project-automation github-project-automation bot moved this from In Progress to Done in activist Board Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- Code Night 🌙 - Worked on during an activist Code Night 🌙 feature New feature or request help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

4 participants