-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add discussion and discussion_entry models to backend #688
Add discussion and discussion_entry models to backend #688
Conversation
movement_id and vote_id are currently not implemented, denoted by comments. Issue activist-org#619
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you! Maintainer checklist
|
Not sure how to implement dummy models for movements and votes, hence the below backend fails:
|
For now we'll just comment them out, @anthonyshibitov :) Thanks! |
Ok, soooo, this is quite weird. @to-sta, the errors that are coming up now for the backend are what I was seeing in PyLint that we said were false positives 🤔 Can you take a look? |
Hi @andrewtavis, maybe its related but the backend workflow discovered static type issues and unsorted imports. Does pylint cover those? I saw that inheritance was missing for the viewsets, that solves most of the static type issues. class DiscussionViewSet:
...
class DiscussionViewSet(viewsets.ModelViewSet[Discussion]):
.... I think the rest of the static type issues are related to the use of model fields that don't exist. |
…ion for update and delete operations
…and formatting issues
I fixed the mypy, linting and formatting issues. @andrewtavis and I renamed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final commit on my end was mostly keeping the changes from the branch here and organizing things. Thanks so much for this, @anthonyshibitov! Always a pleasure, and again apologies that this took so long. Also thanks for the fixes, @to-sta! 😊
Contributor checklist
Description
movement_id and vote_id are currently not implemented, denoted by comments.
Let me know if there's any issues with this. This is my first foray into backend stuff 🤠
Related issue