Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for compressed responses #298

Closed
wants to merge 5 commits into from
Closed

add support for compressed responses #298

wants to merge 5 commits into from

Conversation

thehesiod
Copy link
Collaborator

@thehesiod thehesiod commented Jul 18, 2017 •
edited
Loading

@jettify
Copy link
Member

jettify commented Jul 18, 2017

I just noticed that if I try a aiobotocore s3 client get_object of a key that a Content-Encoding metadata set to gzip, it's automatically decompressing the body as well, not-good...

Good catch! Looks like aiobotocore hits every edge case of aiohttp client possible.

@thehesiod
Copy link
Collaborator Author

thehesiod commented Jul 18, 2017 •
edited
Loading

crazy eh? :) Also my service seems to have found a python segfault after updating a defaultdict a few million times <sigh> that's not going to be fun to track down.

@thehesiod
Copy link
Collaborator Author

oh, and in reality the issue with aiohttp is that it doesn't follow http stack norms :( Basically designed like: I think it should behave like X by default, whereas every other library behaves like Y

@jettify
Copy link
Member

jettify commented Sep 8, 2017

aio-libs/aiohttp#2110 had been merged, do you have idea how we can test this PR?

jettify
jettify reviewed Sep 8, 2017
View reviewed changes
setup.py
@@ -6,7 +6,7 @@

# aiohttp requirement is pegged as we need to manually ensure that
# https://github.com/aio-libs/aiobotocore/pull/248 will continue working
install_requires = ['botocore>=1.5.71, <=1.5.78', 'aiohttp>=2.0.4, <=2.3.0',
install_requires = ['botocore>=1.5.71, <=1.5.78', 'aiohttp>=2.X.X, <=2.X.X',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updates her should fix CI

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya, broken on purpose for now so we set the right version that's needed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it

@thehesiod
Copy link
Collaborator Author

it's been merged but there's no release available with it yet

@jettify jettify mentioned this pull request Oct 15, 2017
Closed
@jettify
Copy link
Member

jettify commented Nov 9, 2017

merged manually here #425

@jettify jettify closed this Nov 9, 2017
@thehesiod thehesiod deleted the thehesiod/compression_fix branch April 3, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jettify jettify jettify left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

S3 get_object of key that has 'Content-Encoding' metadata set to gzip returns wrong data type
2 participants
@thehesiod @jettify