-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update aiohttp #425
Update aiohttp #425
Conversation
Codecov Report
@@ Coverage Diff @@
## master #425 +/- ##
==========================================
+ Coverage 83.49% 87.24% +3.74%
==========================================
Files 8 8
Lines 515 486 -29
==========================================
- Hits 430 424 -6
+ Misses 85 62 -23
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the PR :)
setup.py
Outdated
@@ -9,7 +9,7 @@ | |||
# If adding requirements make sure to also add to requirements-dev.txt | |||
install_requires = [ | |||
'botocore>=1.7.28, <=1.7.40', | |||
'aiohttp>=2.0.4, <=2.3.0', | |||
'aiohttp>=2.3.0, <=2.3.2', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Push <3.0.0
here.
All aiohttp 2.3
bugfixes should be backward compatible.
Honestly I don't expect many of them, maybe one or two with very minor changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
# we can remove the following line and take advantage of | ||
# aws gzip compression. | ||
# See: https://github.com/aio-libs/aiohttp/issues/1992 | ||
headers['Accept-Encoding'] = 'identity' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jettify bug: we need to keep this identity until boto/botocore#1255 is fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, will bring back this lines.
@asvetlov thanks for the redirect and compression fixes! |
@thehesiod you are welcome! |
No description provided.