Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure_coordinator_known -- break loop on self._closing.done() #660

Merged
merged 3 commits into from
Nov 13, 2020

Conversation

dkilgore90
Copy link
Contributor

@dkilgore90 dkilgore90 commented Sep 24, 2020

Changes

Fixes #659

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #660 (83b0f34) into master (f7f55b1) will decrease coverage by 46.50%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #660       +/-   ##
===========================================
- Coverage   97.95%   51.45%   -46.51%     
===========================================
  Files          29       29               
  Lines        5193     5193               
===========================================
- Hits         5087     2672     -2415     
- Misses        106     2521     +2415     
Flag Coverage Δ
cext 41.26% <0.00%> (-46.41%) ⬇️
integration ?
purepy 50.97% <0.00%> (-46.51%) ⬇️
unit 51.45% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiokafka/consumer/group_coordinator.py 9.82% <0.00%> (-89.22%) ⬇️
aiokafka/producer/sender.py 15.00% <0.00%> (-84.55%) ⬇️
aiokafka/consumer/consumer.py 16.46% <0.00%> (-81.44%) ⬇️
aiokafka/cluster.py 20.27% <0.00%> (-79.73%) ⬇️
aiokafka/producer/producer.py 23.00% <0.00%> (-75.50%) ⬇️
aiokafka/conn.py 22.67% <0.00%> (-71.43%) ⬇️
aiokafka/client.py 26.79% <0.00%> (-71.34%) ⬇️
aiokafka/producer/transaction_manager.py 48.04% <0.00%> (-50.28%) ⬇️
aiokafka/consumer/fetcher.py 70.84% <0.00%> (-26.34%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7f55b1...83b0f34. Read the comment docs.

@tvoinarovskyi
Copy link
Member

lgtm 🚢

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ods ods merged commit fff2c02 into aio-libs:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consumer.stop() blocks in GroupCoordinator.ensure_coordinator_known() if all brokers are unavailable
4 participants