Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure_coordinator_known -- break loop on self._closing.done() #660

Merged
merged 3 commits into from
Nov 13, 2020
Merged

ensure_coordinator_known -- break loop on self._closing.done() #660

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c11095
ensure_coordinator_known -- break loop on self._closing.done()
dkilgore90 Sep 24, 2020
38e13a7
Update CHANGES.rst
dkilgore90 Sep 24, 2020
83b0f34
Merge branch 'master' into consumer_stop
dkilgore90 Nov 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,12 @@
Changelog
=========

659.bugfix
Allow group coordinator to close when all brokers are unavailable

628.bugfix
Fix memory leak in kafka consumer when consumer is in idle state not consuming any message
=======

618.feature
added `OAUTHBEARER` as a new `sasl_mechanism`.

Expand Down
2 changes: 1 addition & 1 deletion aiokafka/consumer/group_coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,7 @@ async def ensure_coordinator_known(self):

async with self._coordinator_lookup_lock:
retry_backoff = self._retry_backoff_ms / 1000
while self.coordinator_id is None:
while self.coordinator_id is None and not self._closing.done():
try:
coordinator_id = (
await self._client.coordinator_lookup(
Expand Down