-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contribution-types): adds mentoring #314
Conversation
Seems like the |
@all-contributors please add @mloning for code |
I've put up a pull request to add @mloning! 🎉 |
bump |
Hopefully this will get the `test_and_deploy` check to stop hanging
Hopefully, the required check will stop hanging. |
bump (sorry for doing it again, but it has been a while...) I'll do another PR if it's necessary (#321 ), just let me(us) know what we can do to get this merged. Thanks! |
@jakebolam Any ideas as to why this CI issue happens? |
@Berkmann18 is attempting to deploy a commit to the All Contributors Team on Vercel. A member of the Team first needs to authorize it. |
eeek |
ok, now it is giving some more insightful information: conflicting files.
@mloning can you fix the PR branch? thx |
@omarcostahamido thanks for looking into this. Not sure what I have to do, git tells me the files I changed were deleted on master? Have they been moved? |
The whole project had an overhaul, and the file where you changes would essentially move to is: https://github.com/all-contributors/app/blob/master/lib/parse-comment.js I was hoping to have documentation around the new architecture that will affect the other repos but life got on the way. |
@omarcostahamido @Berkmann18 alright I cleaned it up - anything else still missing or is this good to go? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks a lot!
@gr2m I see that Vercel is having an auth problem, is there anything we can do to fix that? |
Deployment failed with the following error:
|
I had to authorize the deploy because the PR is from a fork. I should be able to invite to the Vercel org, but it's $20/month, that I'm currently paying. Okay if I do the approvals for now, until we either get sponsoring from Vercel, or move to begin.com for deployments (which is something I'd like to do anyway) |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/all-contributors-app/app/rohwwzvkr |
You can install https://github.com/apps/all-contributors-preview for testing the change. Make sure you don't have https://github.com/apps/allcontributors installed on the same repository, the two might conflict with each other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me:
gr2m/sandbox#163 (comment)
🎉 This PR is included in version 1.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
omg, we did it, at last! |
What:
Add support for mentoring (see all-contributors/all-contributors#423)
Why:
How:
Added mentoring to
src/tasks/processIssueComment/utils/parse-comment/index.js
Checklist:
Comments:
If tests are needed, could you point me to the files that I have to change/add?