Artemis Console next gen based on hawtIO 4 #5441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbertram
reviewed
Jan 16, 2025
| "favicon": "img/favicon.png" | ||
| }, | ||
| "login": { | ||
| "description": "Login page for Artemis Console.", |
There was a problem hiding this comment.
Should be, "Login page for ActiveMQ Artemis Console."
jbertram
reviewed
Jan 16, 2025
| }, | ||
| "about": { | ||
| "title": "ActiveMQ Artemis Management Console", | ||
| "productInfo": [{"name": "Artemis", "value": "${project.version}"}], |
There was a problem hiding this comment.
Should be, "ActiveMQ Artemis".
gemmellr
reviewed
Jan 22, 2025
...s-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/hawtio-oidc.properties
Show resolved
Hide resolved
Comment on lines
+123
to
+125
| <artifactId>apache-artemis-console</artifactId> | ||
| <type>zip</type> | ||
| <classifier>bin</classifier> |
There was a problem hiding this comment.
The changes in the pom overall result in inclusion of the console zip and the war in the distribution lib dir.
This should probably marked as provided as its only here for build time use (or maybe it could even be omitted, given it is specified in the dependency unpack execution)
andytaylor
force-pushed
the
2.39.0-console-ng
branch
from
bf8fd19 to
082ae93
Compare
|
Replaced by #5467. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to allow developers to build a variant of the latest Artemis Release with the new Artemis Console embedded, for testing. It will not currently merge and isnt intended to. It replaces #5245
The next Artemis Console release candidate, 1.1.0, and this build will use the staged dependency when built.
This PR is a draft and will be updated/reaplced for each Artemis Release until it is decided to merge into main.