handle overflow in gcd and return this as an error #11057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jun 22, 2024
There was a problem hiding this comment.
Thank you @LorrensP-2158466 -- this looks good to me
I took the liberty of merging this PR up from main as well as adding a .slt test
|
Thanks! |
|
Thanks again @LorrensP-2158466 |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* handle overflow in gcd and return this as an error * Add SLT test --------- Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11053.
Rationale for this change
What changes are included in this PR?
GCD and LCM functions can now return an integer overflow error in the form of an
ArrowError::Compute(absimpl does this too).Are these changes tested?
Yes, added a unit test that tries to overflow
Are there any user-facing changes?
Users may see overflow errors instead of incorrect results