-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed github workflows, set unique service names of dubbo-samples-triple-rest-openapi-basic and dubbo-samples-triple-servlet #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
5f8ac4e
to
138dcd5
Compare
138dcd5
to
d83efe7
Compare
72aeb37
to
49302fb
Compare
1833169
to
b9a1ec7
Compare
i found other two problems,
|
…i-basic to avoid being affected by other zookeeper tests
…d being affected by other nacos tests
b9a1ec7
to
dde1153
Compare
The service names defined in case-configuration.yml should be unique among all test modules to avoid affecting each other because github Actions might run more than one test modules at the same time. |
deecdd1
to
f656789
Compare
d7ecb88
to
0df1160
Compare
0df1160
to
3176b79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try to solve
dubbo-samples-triple-rest-openapi-basic
that was always timeout which might be caused by using same zookeeper service name among different test jobs, those jobs might be running on the same time and one of them might destroy the zookeeper service while other are still running.dubbo-samples-triple-servlet
that was always timeout which might be caused by using same nacos service name among different test jobs, those jobs might be running on the same time and one of them might destroy the nacos service while other are still running.3.1
dubbo-samples-triple-servlet
has another problem: NPE will be thrown atHttpMetadataAdapter.headers
asrequest.getHeader(HttpHeaderNames.HOST.getName())
returns null, but it could not be fixed by this pull request, it had been fixed by [3.3] Get authority by calling HttpServletRequest#getServerName dubbo#15141 which usedrequest.getServerName()
instead.@AlbumenJ PTAL