Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed github workflows, set unique service names of dubbo-samples-triple-rest-openapi-basic and dubbo-samples-triple-servlet #1206

Merged
merged 7 commits into from
Feb 19, 2025

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Feb 14, 2025

try to solve

  1. there were too many dubbo-samples github Actions errors should be fixed, since upload-artifact@v4 (fix:apollo update docker image to jdk17 #1203) does not support uploading same test result name for different jobs anymore.
  2. dubbo-samples-triple-rest-openapi-basic that was always timeout which might be caused by using same zookeeper service name among different test jobs, those jobs might be running on the same time and one of them might destroy the zookeeper service while other are still running.
  3. dubbo-samples-triple-servlet that was always timeout which might be caused by using same nacos service name among different test jobs, those jobs might be running on the same time and one of them might destroy the nacos service while other are still running.
    3.1 dubbo-samples-triple-servlet has another problem: NPE will be thrown at HttpMetadataAdapter.headers as request.getHeader(HttpHeaderNames.HOST.getName()) returns null, but it could not be fixed by this pull request, it had been fixed by [3.3] Get authority by calling HttpServletRequest#getServerName dubbo#15141 which used request.getServerName() instead.

@AlbumenJ PTAL

@zrlw zrlw changed the title Uniquified upload name and path of test result name, fixed dubbo-samples-triple-rest-openapi-basic module Uniquified upload name and path of test result name for actions/upload-artifact@v4, fixed dubbo-samples-triple-rest-openapi-basic module Feb 15, 2025
@zrlw zrlw mentioned this pull request Feb 15, 2025
@zrlw zrlw force-pushed the patch-workflows branch 4 times, most recently from 5f8ac4e to 138dcd5 Compare February 15, 2025 15:58
@zrlw zrlw changed the title Uniquified upload name and path of test result name for actions/upload-artifact@v4, fixed dubbo-samples-triple-rest-openapi-basic module fixed github workflows and dubbo-samples-triple-rest-openapi-basic module Feb 15, 2025
@zrlw zrlw force-pushed the patch-workflows branch 4 times, most recently from 72aeb37 to 49302fb Compare February 16, 2025 04:10
@zrlw zrlw changed the title fixed github workflows and dubbo-samples-triple-rest-openapi-basic module fixed github workflows, limit zookeeper version of dubbo-samples-triple-rest-openapi-basic,limit nacos version of dubbo-samples-triple-servlet Feb 16, 2025
@zrlw zrlw changed the title fixed github workflows, limit zookeeper version of dubbo-samples-triple-rest-openapi-basic,limit nacos version of dubbo-samples-triple-servlet fixed github workflows, limit zookeeper version of dubbo-samples-triple-rest-openapi-basic, nacos version of dubbo-samples-triple-servlet Feb 16, 2025
@zrlw zrlw force-pushed the patch-workflows branch 2 times, most recently from 1833169 to b9a1ec7 Compare February 16, 2025 05:49
@zrlw
Copy link
Contributor Author

zrlw commented Feb 16, 2025

i found other two problems,

  1. dubbo-samples-triple-rest-openapi-basic could not be tested while dubbo-samples-zookeeper is running, dubbo-samples-zookeeper will run about 32 minutes as it will test all 3.6.0+ zookeeper versions excluding temurin versions from https://hub.docker.com/v2/namespaces/library/repositories/zookeeper/tags which is set in dubbo-samples-zookeeper case-version-sources.conf.
[dubbo-samples-triple-rest-openapi-basic] Starting containers ..
[dubbo-samples-zookeeper] Waiting for test container dubbo-samples-zookeeper--dubbo-samples-zookeeper-test-1 ..
[dubbo-samples-zookeeper] Run tests successfully
[dubbo-samples-zookeeper] Stopping containers ..
[dubbo-samples-triple-rest-openapi-basic] Waiting for test container dubbo-samples-triple-rest-openapi-basic--test-1 ..
... ... ...
wait for container is timeout: 602 s
[dubbo-samples-triple-rest-openapi-basic] :ErrorMsg: Run tests timeout
  1. dubbo-samples-triple-servlet could not be tested while dubbo-samples-nacos-registry is running, dubbo-samples-nacos-registry will run about 18+ minutes as it will test all nacos versions excluding ALPHA and BETA versions from https://repo1.maven.org/maven2/com/alibaba/nacos/nacos-client/maven-metadata.xml which is set indubbo-samples-nacos-registry case-version-sources.conf.
[7/20] [dubbo-samples-nacos-registry:3/23] Running test case ..
[dubbo-samples-nacos-registry] Killing containers ..
[dubbo-samples-nacos-registry] Removing containers ..
[dubbo-samples-nacos-registry] Starting containers ..
[dubbo-samples-triple-servlet] Waiting for test container dubbo-samples-triple-servlet--test-1 ..
[dubbo-samples-nacos-registry] Waiting for test container dubbo-samples-nacos-registry--dubbo-samples-nacos-registry-test-1 ..
[dubbo-samples-triple-servlet] :ErrorMsg: Run tests failed
[dubbo-samples-triple-servlet] Stopping containers ..

zrlw added 2 commits February 16, 2025 15:54
…i-basic to avoid being affected by other zookeeper tests
@zrlw zrlw changed the title fixed github workflows, limit zookeeper version of dubbo-samples-triple-rest-openapi-basic, nacos version of dubbo-samples-triple-servlet fixed github workflows, modified zookeeper service name of dubbo-samples-triple-rest-openapi-basic, modified nacos service name of dubbo-samples-triple-servlet Feb 16, 2025
@zrlw
Copy link
Contributor Author

zrlw commented Feb 16, 2025

The service names defined in case-configuration.yml should be unique among all test modules to avoid affecting each other because github Actions might run more than one test modules at the same time.

@zrlw zrlw changed the title fixed github workflows, modified zookeeper service name of dubbo-samples-triple-rest-openapi-basic, modified nacos service name of dubbo-samples-triple-servlet fixed github workflows, set unique service names of dubbo-samples-triple-rest-openapi-basic and dubbo-samples-triple-servlet Feb 16, 2025
@zrlw zrlw force-pushed the patch-workflows branch 2 times, most recently from deecdd1 to f656789 Compare February 16, 2025 14:50
@zrlw zrlw force-pushed the patch-workflows branch 3 times, most recently from d7ecb88 to 0df1160 Compare February 17, 2025 06:20
@AlbumenJ AlbumenJ merged commit 1f40d5c into apache:master Feb 19, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants