Feat(eos_designs): Add support for RSS interface profile for select p…

[ashenoy-arista]

Change Summary

Build schema for eos_designs role to help generate structured config for RSS interface profile.
RSS interface profile is only applicable to certain SFE (Software Forwarding Engine) hardware platforms.
We would like to have toggle/knob under platform_settings -> feature_support schema that end-user can enable for supported hardware platforms to allow generation of relevant structured config.

Related Issue(s)

Fixes #4983

Component(s) name

arista.avd.eos_designs

Proposed changes

Propose adding rx_queue dictionary type under L3 interface and member eth interfaces of L3 Port-Channel interface.
The keys within this dictionary would be count, worker and mode.
Add a knob under platform_settings -> feature_support schema. When enabled, underlying logic would generate structured config for RSS profile for devices capable of supporting this feature. Such profile would include sections for each interface for which rx_queue dictionary type has been specified/populated in yml.
There will be only one such RSS profile generated and same profile would be set as the chosen profile to apply for the system.

How to test

TBD

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5009
# Activate the virtual environment
source test-avd-pr-5009/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ashenoy-arista/avd.git@eosDesignsRssProfileSupport#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ashenoy-arista/avd.git#/ansible_collections/arista/avd/,eosDesignsRssProfileSupport --force
# Optional: Install AVD examples
cd test-avd-pr-5009
ansible-playbook arista.avd.install_examples

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[ashenoy-arista]

Initial logic implementation in eos_designs to validate input yml and generate structured config for RSS profiles.
Molecule unit test has been added.
Negative unit test cases to be added next.

[ashenoy-arista]

Updated few newly added input yml schema keys.
Added unit tests under eos_designs_unit_tests and eos_designs_negative_unit_tests.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[ClausHolbechArista]

I think all these helper methods could live in a UtilsMixin for the base structured config module. Remember to prefix them with underscore if they are cached properties. (They are not shared when they are not used across multiple modules).

You can also choose to split out the platform part into it's own mixin and keep the helpers there if that is better?

[ashenoy-arista]

Added helper methods to PlatformMixin class
Tried moving existing platform() method from structured_config/base/init.py to this class.
But it was not generating platform key in yml files for structured config (regardless of decorator cached_property or structured_config_contributor)
Hence did not move platform() cached property to PlatformMixin class.
Please let me know if this method can be moved and what should be the decorator.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud