[red-knot] Ensure differently ordered unions and intersections are understood as equivalent even inside arbitrarily nested tuples #15740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
requested review from
carljm,
MichaReiser and
sharkdp
as code owners
AlexWaygood
changed the title
AlexWaygood
force-pushed
the
alex/nested-tuples
branch
from
226a4cb to
a727e80
Compare
carljm
approved these changes
Jan 25, 2025
AlexWaygood
commented
Jan 25, 2025
Comment on lines
-1157
to
+1186
| _ => self.is_fully_static(db) && other.is_fully_static(db) && self == other, | ||
| _ => self == other && self.is_fully_static(db) && other.is_fully_static(db), |
There was a problem hiding this comment.
we have a teeny tiny speedup on Codspeed, which I suspect is just due to the change on this line
dcreager
added a commit
that referenced
this pull request
Jan 27, 2025
* main: Run `cargo update` (#15769) [red-knot] Document public symbol type inferece (#15766) Update dawidd6/action-download-artifact action to v8 (#15760) Update NPM Development dependencies (#15758) Update pre-commit dependencies (#15756) Update dependency ruff to v0.9.3 (#15755) Update dependency mdformat-mkdocs to v4.1.2 (#15754) Update Rust crate uuid to v1.12.1 (#15753) Update Rust crate unicode-ident to v1.0.15 (#15752) Fix docstring in ruff_annotate_snippets (#15748) Update Rust crate insta to v1.42.1 (#15751) Update Rust crate clap to v4.5.27 (#15750) Add references to `trio.run_process` and `anyio.run_process` (#15761) [`ruff`] Do not emit diagnostic when all arguments to `zip()` are variadic (`RUF058`) (#15744) [red-knot] Ensure differently ordered unions are considered equivalent when they appear inside tuples inside top-level intersections (#15743) [red-knot] Ensure differently ordered unions and intersections are understood as equivalent even inside arbitrarily nested tuples (#15740) [red-knot] Promote the `all_type_pairs_are_assignable_to_their_union` property test to stable (#15739) [`pylint`] Do not trigger `PLR6201` on empty collections (#15732) Improve the file watching failure error message (#15728) Speed symbol state merging back up (#15731)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On
main, red-knot:P | Qequivalent toQ | Ptuple[P | Q]equivalent totuple[Q | P]tuple[P | tuple[P | Q]]equivalent totuple[tuple[Q | P] | P]tuple[tuple[P | Q]]equivalent totuple[tuple[Q | P]]The key difference for the last one of these is that the union appears inside a tuple that is directly nested inside another tuple.
This PR fixes this so that differently ordered unions are considered equivalent even when they appear inside arbitrarily nested tuple types.
Test Plan
main