Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the node clean up failure without auto mode #547

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

wwvela
Copy link
Contributor

@wwvela wwvela commented Jan 7, 2025

Issue #, if available:
Find below error when deleting unmanaged node group without AutoMode. Fix by only clean up these resources when it is AutoMode

January 06, 2025 at 15:02 (UTC-8:00)
Error: failed to delete node pool: no matches for kind "NodePool" in version "karpenter.sh/v1"
	
January 06, 2025 at 15:02 (UTC-8:00)
I0106 23:02:28.920402 12 node.go:289] placeholder deployment does not exist: kubetest2-eksapi-f0b52762-d024-466e-b8dd-08ba7cf96d3e
	
January 06, 2025 at 15:02 (UTC-8:00)
I0106 23:02:28.920421 12 node.go:218] deleting node pool...
	
January 06, 2025 at 15:02 (UTC-8:00)
I0106 23:02:28.205830 12 node.go:586] nodegroup does not exist: kubetest2-eksapi-f0b52762-d024-466e-b8dd-08ba7cf96d3e
	
January 06, 2025 at 15:02 (UTC-8:00)
I0106 23:02:28.205850 12 node.go:286] deleting placeholder deployment...

@wwvela wwvela requested a review from cartermckinnon January 7, 2025 19:30
@cartermckinnon cartermckinnon merged commit 9bdcb4f into aws:main Jan 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants