Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the node clean up failure without auto mode #547

Merged
merged 1 commit into from
Jan 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions kubetest2/internal/deployers/eksapi/deployer.go
Original file line number Diff line number Diff line change
Expand Up @@ -321,11 +321,11 @@ func (d *deployer) Down() error {
if d.deployerOptions.StaticClusterName != "" {
return d.staticClusterManager.TearDownNodeForStaticCluster()
}
return deleteResources(d.infraManager, d.clusterManager, d.nodeManager, d.k8sClient)
return deleteResources(d.infraManager, d.clusterManager, d.nodeManager, d.k8sClient, &d.deployerOptions)
}

func deleteResources(im *InfrastructureManager, cm *ClusterManager, nm *nodeManager /* nillable */, k8sClient *k8sClient) error {
if err := nm.deleteNodes(k8sClient); err != nil {
func deleteResources(im *InfrastructureManager, cm *ClusterManager, nm *nodeManager /* nillable */, k8sClient *k8sClient, opts *deployerOptions) error {
if err := nm.deleteNodes(k8sClient, opts); err != nil {
return err
}
// the EKS-managed cluster security group may be associated with a leaked ENI
Expand Down
2 changes: 1 addition & 1 deletion kubetest2/internal/deployers/eksapi/janitor.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func (j *janitor) Sweep(ctx context.Context) error {
clusterManager := NewClusterManager(clients, resourceID)
nodeManager := NewNodeManager(clients, resourceID)
klog.Infof("deleting resources (%v old): %s", resourceAge, resourceID)
if err := deleteResources(infraManager, clusterManager, nodeManager /* TODO: pass a k8sClient */, nil); err != nil {
if err := deleteResources(infraManager, clusterManager, nodeManager /* TODO: pass a k8sClient */, nil, nil); err != nil {
errs = append(errs, fmt.Errorf("failed to delete resources: %s: %v", resourceID, err))
}
}
Expand Down
4 changes: 2 additions & 2 deletions kubetest2/internal/deployers/eksapi/node.go
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@ func (m *nodeManager) createUnmanagedNodegroupWithEFA(infra *Infrastructure, clu
// deleteNodes cleans up any nodes in the cluster
// it will be called outside the context of a deployer run (by the janitor, for example)
// so will try to delete nodes of any type
func (m *nodeManager) deleteNodes(k8sClient *k8sClient) error {
func (m *nodeManager) deleteNodes(k8sClient *k8sClient, opts *deployerOptions) error {
if err := m.deleteUnmanagedNodegroup(); err != nil {
return err
}
Expand All @@ -559,7 +559,7 @@ func (m *nodeManager) deleteNodes(k8sClient *k8sClient) error {
}
// we only have a k8sClient when this is called by the deployer, not by the janitor
// TODO implement cleanup of Auto nodes in the janitor
if k8sClient != nil {
if k8sClient != nil && opts != nil && opts.AutoMode {
if err := m.deletePlaceholderDeployment(k8sClient); err != nil {
return err
}
Expand Down
Loading