Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change bannerComment property to use ESLint, since TSLint has been deprecated for quite a bit #380

Closed
krishnagopinath opened this issue Mar 30, 2021 · 5 comments · Fixed by #474

Comments

@krishnagopinath
Copy link

krishnagopinath commented Mar 30, 2021

Thank you for this wonderful project, @bcherny!

Since TSLint was deprecated in 2019, I wonder if it would make sense to update the bannerComment property's default to use eslint-disable instead of tslint:disable.

@dianjuar
Copy link

This is a need.

I'm on a project that uses eslint and each time that I generate a new schema I have to modify by hand the banner.

Feels quite bad, especially having a comment just below that tolds you DO NOT MODIFY IT BY HAND

@DaSchTour
Copy link

For the start there could also be both

@bcherny
Copy link
Owner

bcherny commented Sep 12, 2021

PRs welcome to add ESLint suppression in addition to the existing TSLint suppression.

@dianjuar
Copy link

dianjuar commented Sep 13, 2021

@bcherny I would like to implement this feature.

@bcherny I don't know how do you manage the help-wanted tag, but I would like to be assigned to this issue.

@JoshuaKGoldberg
Copy link
Contributor

Can we do away with TSLint altogether, please? TSLint's been deprecated since 2019 and hasn't received any updates for security fixes or new TypeScript syntax in years. A lot of folks get confused about the difference in terminology with tslint vs. lint vs. eslint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants