Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace TSLint disables with ESLint #474

Merged
merged 1 commit into from
Aug 7, 2022
Merged

fix: replace TSLint disables with ESLint #474

merged 1 commit into from
Aug 7, 2022

Conversation

JoshuaKGoldberg
Copy link
Contributor

Fixes #380.

Unlike #429, adheres to #380 (comment) (doing away with TSLint altogether).

bcherny
bcherny approved these changes Aug 6, 2022
View reviewed changes
Copy link
Owner

@bcherny bcherny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@bcherny
Copy link
Owner

bcherny commented Aug 6, 2022

Mind rebasing? Then will be happy to merge!

@bcherny bcherny mentioned this pull request Aug 6, 2022
Closed
@JoshuaKGoldberg JoshuaKGoldberg requested a review from bcherny August 6, 2022 20:31
@bcherny bcherny merged commit 1a45ce3 into bcherny:master Aug 7, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the eslint-not-tslint branch August 7, 2022 13:23
@yamazaki-sensei yamazaki-sensei mentioned this pull request Sep 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcherny bcherny Awaiting requested review from bcherny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change bannerComment property to use ESLint, since TSLint has been deprecated for quite a bit
2 participants
@JoshuaKGoldberg @bcherny