Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for es-lint #429

Closed
wants to merge 1 commit into from

Conversation

dianjuar
Copy link

@dianjuar dianjuar commented Dec 31, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What is the current behavior?

Issue Number: #380

What is the new behavior?

Change the banner generated to disable es-lint too.

Does this PR introduce a breaking change?

  • Yes
  • No

Change the banner generated to disable es-lint too
@dianjuar dianjuar marked this pull request as draft December 31, 2021 06:53
@dianjuar
Copy link
Author

dianjuar commented Dec 31, 2021

The tests are failing, I need to change the expected output with the new banner, but I don't know how to do it.

I tried changing test/__snapshots__/test/test.ts.md but seems not to work.

Guidance is appreciated

@bcherny
Copy link
Owner

bcherny commented May 1, 2022

Thanks for the contribution! You want yarn test --update-snapshots.

See https://github.com/avajs/ava/blob/main/docs/04-snapshot-testing.md

@bcherny
Copy link
Owner

bcherny commented May 1, 2022

Closing for now, but feel free to re-open if you update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants