Integrate new wallet address manager package #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,6 +56,7 @@ var ( | |||
|
|
|||
| type config struct { | |||
| ShowVersion bool `short:"V" long:"version" description:"Display version information and exit"` | |||
| Create bool `long:"create" description:"Create initial wallet"` | |||
There was a problem hiding this comment.
Don't think "initial" is the word we want here. That almost makes it sound like we support having many wallets open at a time.
Perhaps the description should also mention how this option prevents normal operation by exiting once the wallet is created.
This was referenced Oct 14, 2014
Closed
|
We also need to update the README.md to remove references to Armory and (ideally) describe that btcwallet is now a HD wallet / BIP0032 compatible. |
|
Couple other things:
|
|
|
||
| } else if !fileExists(mgrPath) { | ||
| err := fmt.Errorf("The wallet does not exist. Run with the " + | ||
| "--create option to initialize and create it.") |
There was a problem hiding this comment.
As discussed on IRC, we can indicate that '--create' also imports legacy keystore. Maybe update it to:
The wallet does not exist. Run with the --create option to initialize, create it and automatically import any existing legacy wallet.
davecgh
force-pushed
the
davec_intwaddrmgr
branch
from
8f623f1 to
66bc769
Compare
davecgh
force-pushed
the
davec_intwaddrmgr
branch
from
66bc769 to
ec8a5bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request converts the wallet to use the new secure hierarchical deterministic wallet address manager package.
The following is an overview of modified functionality:
--createhas been added to create the new wallet using wizard style question and answer prompts--create--createflag with an existing wallet will simply show an error and return--createflag will prompt you for the old private passphrase and automatic convert all old addresses to the new wallet being created