-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate new wallet address manager package #147
Conversation
a715835
to
8f1cd24
Compare
I've rebased this on top of #153. |
77fd5f1
to
d851527
Compare
Rebased and updated for changes in #152. |
For anyone wondering about the status of this, it is being maintained until the current |
ca86ac1
to
2d8a8be
Compare
2d8a8be
to
4308841
Compare
I've rebased this to the latest master and updated all go subrepo import paths for their new locations. |
08f2a34
to
bbeea62
Compare
6754fc5
to
9f9bd9c
Compare
This has been updated to include all of the new paths and rebased accordingly. |
Because accounts are created with 0 addresses, but manager.LastExternalAddress returns the next address without error (which is not yet watched or managed), the getaccountaddress RPC is currently broken. To fix, we will need to add Num{Internal,External}Addresses methods to the manager and check for 0 external addresses in the GetAccountAddress handler. |
Another option is to create the first address on the internal and external branches when an account is created. |
9f9bd9c
to
92122f8
Compare
This has been updated for the btcscript -> btcd/txscript move and rebased accordingly. |
This commit converts the wallet to use the new secure hierarchical deterministic wallet address manager package as well as the walletdb package. The following is an overview of modified functionality: - The wallet must now be created before starting the executable - A new flag --create has been added to create the new wallet using wizard style question and answer prompts - Starting the process without an existing wallet will instruct now display a message to run it with --create - Providing the --create flag with an existing wallet will simply show an error and return
92122f8
to
3e7cba0
Compare
Previously a runtime.GC was being invoked which forced it to release the memory as far as the garbage collector is concerned, but the memory was not released back to the OS immediatley. This modification allows the memory to be released immedately since it won't be needed again until the next wallet unlock.
3e7cba0
to
51e3d5f
Compare
I've pushed a intwaddrmgr branch to this repo. The keystore->waddrmgr replacement and integration here is in good shape but there are several other components (like txstore -> wtxmgr) that we want to complete before pushing this to master. PRs which depend on intwaddr should be rebased to this branch and submitted as a intwaddrmgr PR (not a PR to master). |
This pull request converts the wallet to use the new secure hierarchical deterministic wallet address manager package.
The following is an overview of modified functionality:
--create
has been added to create the new wallet using wizard style question and answer prompts--create
--create
flag with an existing wallet will simply show an error and return--create
flag will prompt you for the old private passphrase and automatic convert all old addresses to the new wallet being createdGithub seems to have incorrectly closed the previous pull request #138.