Mark addresses used #183
Closed
Mark addresses used #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I took a very quick look and noticed that the serialization formation of addresses has been changed, but there is no code to upgrade the existing addresses which will be in the old format. |
|
OK, didn't consider that since the integration branch is not on master, but I'll add it in case anyone is already using the branch. |
tuxcanfly
force-pushed
the
single-use-addr
branch
from
3b73209 to
d3c4e23
Compare
This commit converts the wallet to use the new secure hierarchical deterministic wallet address manager package as well as the walletdb package. The following is an overview of modified functionality: - The wallet must now be created before starting the executable - A new flag --create has been added to create the new wallet using wizard style question and answer prompts - Starting the process without an existing wallet will instruct now display a message to run it with --create - Providing the --create flag with an existing wallet will simply show an error and return
Previously a runtime.GC was being invoked which forced it to release the memory as far as the garbage collector is concerned, but the memory was not released back to the OS immediatley. This modification allows the memory to be released immedately since it won't be needed again until the next wallet unlock.
Conflicts: btcwallet.go chain/chain.go wallet.go
tuxcanfly
force-pushed
the
single-use-addr
branch
from
d3c4e23 to
744319d
Compare
tuxcanfly
force-pushed
the
single-use-addr
branch
from
744319d to
d09ce1d
Compare
|
Looks like build failed due to travis:
A forced rebuild should set this back to green. |
|
Closing in favor of #196 which is based on intwaddrmgr instead of master |
jcvernaleo
pushed a commit
to jcvernaleo/btcwallet
that referenced
this pull request
Apr 18, 2016
* Ticket purchasing code overhaul This pull request removes the old, buggy ticket purchase code and replaces it with code that is more robust. In particular, chains of tickets can now be purchased with ease because outputs to be consumed by tickets are now pregenerated in split transactions. Ticket expiry can now be added to ensure that the tickets will expire in a short time frame, so that the end user can update the ticket fees if their tickets fail to be added to a block. A new feature that was added was pool fees. Tickets can now pay a fee to a pool that is set by the user. The fee determines the amount that the user will contribute to the pool. The pool then receives this amount plus subsidy.
jrick
pushed a commit
to jrick/btcwallet
that referenced
this pull request
Nov 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a database flag on Address to mark used addresses and prevent address re-use.