Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minimal exporter and creator acceptance tests #698

Merged
merged 15 commits into from
Aug 30, 2021
Merged

Add minimal exporter and creator acceptance tests #698

merged 15 commits into from
Aug 30, 2021

Conversation

natalieparellano
Copy link
Member

Fixes #692

natalieparellano and others added 14 commits August 23, 2021 14:10
@natalieparellano
Create scaffold
c8913c7 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Check output image in registry
7a806ca 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Check output image in daemon
9947243 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Fix
4adb093 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Check output cache image
1c4fb0f 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Fix
707900a 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Skip cache image check
9918f4c 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Add minimal creator tests
60bd4ca 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Introduce "phase" acceptance test helpers and update analyze tests to…
cf765bb 
… use them

Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Acceptance tests are all passing maybe
bfd251c 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Tests are passing
11e6fad 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Remove unused functions
2d29967 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Remove TODO
0cddff5 
Signed-off-by: Natalie Arellano <[email protected]>
@jjbustamante @natalieparellano
Remove TODOs
5370d02 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano natalieparellano requested a review from a team as a code owner August 26, 2021 21:28
@natalieparellano
Copy link
Member Author

These tests (in particular TestCreator and TestExporter) are passing on an arm machine. @buildpacks/implementation-maintainers anything else we want to see before we ship the arm binaries? cc @imjasonh

@natalieparellano @jjbustamante
Try to fix Windows
0bae59e 
Signed-off-by: Juan Bustamante <[email protected]>
@natalieparellano natalieparellano changed the title Exporter acceptance Add minimal exporter and creator acceptance tests Aug 30, 2021
jabrown85
jabrown85 approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@jabrown85 jabrown85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!!

@natalieparellano natalieparellano mentioned this pull request Aug 30, 2021
Merged
@natalieparellano natalieparellano merged commit 7af70d2 into main Aug 30, 2021
@natalieparellano natalieparellano deleted the exporter-acceptance branch August 30, 2021 17:08
This was referenced Sep 10, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jabrown85 jabrown85 jabrown85 approved these changes

@aemengo aemengo aemengo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minimal acceptance tests for exporter
4 participants
@natalieparellano @jabrown85 @aemengo @jjbustamante