Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on arm in CI #699

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Run tests on arm in CI #699

merged 1 commit into from
Aug 30, 2021

Conversation

natalieparellano
Copy link
Member

Signed-off-by: Natalie Arellano [email protected]

@natalieparellano natalieparellano requested a review from a team as a code owner August 30, 2021 16:59
@natalieparellano
Copy link
Member Author

Blocked on #698

Signed-off-by: Natalie Arellano <[email protected]>
go-version: '1.16'
- name: Test
run: |
make format || true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make format fails on the arm machine... the build directives might need to be updated. In the interest of time, I made this a part of #697.

@natalieparellano natalieparellano changed the title Try to run tests on arm machine Run tests on arm in CI Aug 30, 2021
Copy link
Contributor

@jabrown85 jabrown85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Great work! 🎉

Exciting stuff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants