Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tox.ini and pyproject.toml, and apply new formatting rules #26

Merged
merged 6 commits into from
Feb 12, 2025
Merged

Update tox.ini and pyproject.toml, and apply new formatting rules #26

merged 6 commits into from
Feb 12, 2025
+100 −29

Conversation

chanchiwai-ray
Copy link
Contributor

@chanchiwai-ray chanchiwai-ray commented Feb 10, 2025 •
edited
Loading

Update tox.ini and pyproject.toml, and apply new formatting rules.

This should fix the issue in #25

@chanchiwai-ray chanchiwai-ray requested a review from a team as a code owner February 10, 2025 02:38
@chanchiwai-ray
Copy link
Contributor Author

looks like there's broken dependency in the charm build 😞

@gabrielcocenza gabrielcocenza mentioned this pull request Feb 11, 2025
Merged
@chanchiwai-ray chanchiwai-ray changed the title Update tox.ini and pyproject.toml Update tox.ini and pyproject.toml, and apply new formatting rules Feb 12, 2025
samuelallan72
samuelallan72 previously approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@samuelallan72 samuelallan72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor nit about the formatting

@gabrielcocenza gabrielcocenza merged commit a2fbf03 into main Feb 12, 2025
5 checks passed
@gabrielcocenza gabrielcocenza deleted the fix-lint branch February 12, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelallan72 samuelallan72 samuelallan72 approved these changes

@gabrielcocenza gabrielcocenza gabrielcocenza approved these changes

@Vultaire Vultaire Awaiting requested review from Vultaire Vultaire is a code owner automatically assigned from canonical/soleng-reviewers

@Pjack Pjack Awaiting requested review from Pjack Pjack is a code owner automatically assigned from canonical/soleng-reviewers

@jneo8 jneo8 Awaiting requested review from jneo8 jneo8 is a code owner automatically assigned from canonical/soleng-reviewers

@Deezzir Deezzir Awaiting requested review from Deezzir Deezzir is a code owner automatically assigned from canonical/soleng-reviewers

@sbparke sbparke Awaiting requested review from sbparke sbparke is a code owner automatically assigned from canonical/soleng-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chanchiwai-ray @samuelallan72 @gabrielcocenza