Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix charm install hook by pinning setuptools #27

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Fix charm install hook by pinning setuptools #27

merged 1 commit into from
Feb 12, 2025
+2 −0

Conversation

gabrielcocenza
Copy link
Member

@gabrielcocenza gabrielcocenza commented Feb 11, 2025 •
edited
Loading

  • pin setuptools to be able to install without errors
  • Setuptools 71 will prefer installed dependencies over the vendored ones and this is currently breaking the instalation

More details can be found at:

@gabrielcocenza
- pin setuptools to be able to install without errors
d870167 
- Setuptools 71 will prefer installed dependencies over the vendored ones and this is currently breaking the instalation

More details can be found at:
- pypa/setuptools#4483
- pypa/packaging-problems#342
@gabrielcocenza gabrielcocenza changed the title - pin setuptools to be able to install without errors Fix charm install hook by pinning setuptools Feb 11, 2025
@gabrielcocenza gabrielcocenza marked this pull request as ready for review February 11, 2025 17:07
@gabrielcocenza gabrielcocenza requested a review from a team as a code owner February 11, 2025 17:07
@gabrielcocenza
Copy link
Member Author

@chanchiwai-ray after merging this we can rebase #26

samuelallan72
samuelallan72 approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@samuelallan72 samuelallan72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelallan72 samuelallan72 merged commit 4d94fb5 into canonical:main Feb 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelallan72 samuelallan72 samuelallan72 approved these changes

@jneo8 jneo8 jneo8 approved these changes

@Vultaire Vultaire Awaiting requested review from Vultaire Vultaire is a code owner automatically assigned from canonical/soleng-reviewers

@Pjack Pjack Awaiting requested review from Pjack Pjack is a code owner automatically assigned from canonical/soleng-reviewers

@Deezzir Deezzir Awaiting requested review from Deezzir Deezzir is a code owner automatically assigned from canonical/soleng-reviewers

@chanchiwai-ray chanchiwai-ray Awaiting requested review from chanchiwai-ray chanchiwai-ray is a code owner automatically assigned from canonical/soleng-reviewers

@sbparke sbparke Awaiting requested review from sbparke sbparke is a code owner automatically assigned from canonical/soleng-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrielcocenza @samuelallan72 @jneo8