Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter '-StopOnPackageFailure' should work without requiring parameter '-RebootCodes' #451

Closed
mwallner opened this issue Oct 19, 2020 · 1 comment · Fixed by #452
Closed

Parameter '-StopOnPackageFailure' should work without requiring parameter '-RebootCodes' #451

mwallner opened this issue Oct 19, 2020 · 1 comment · Fixed by #452
Assignees
@mwallner
Labels
5 - Released The issue has been resolved, and released to the public for consumption Bug Issues where something has happened which was not expected or intended Priority_HIGH Issues that are considered to be a high priority to get fixed
Milestone
3.0.0

Comments

@mwallner
Copy link
Member

What You Are Seeing?

Boxstarter parameter StopOnPackageFailure is being ignored when 'RebootCodes' is specified.
Also, StopOnPackageFailure may be wrongfully passed as Chocolatey package name.

What Is Expected?

  • StopOnPackageFailure should work even if RebootCodes is not specified
  • Boxstarter exclusive parameters should be stripped and never passed to Chocolatey.
@mwallner mwallner added Bug Issues where something has happened which was not expected or intended 0 - _Triaging Issue is accepted, but a milestone has yet to be added for the issue labels Oct 19, 2020
@mwallner mwallner self-assigned this Oct 19, 2020
@pauby pauby added the Priority_HIGH Issues that are considered to be a high priority to get fixed label Oct 19, 2020
@pauby pauby changed the title Parameter 'StopOnPackageFailure' only works when passed together with 'RebootCodes' Parameter 'StopOnPackageFailure' should work without requiring parameter 'RebootCodes' Oct 19, 2020
@pauby pauby changed the title Parameter 'StopOnPackageFailure' should work without requiring parameter 'RebootCodes' Parameter '-StopOnPackageFailure' should work without requiring parameter '-RebootCodes' Oct 19, 2020
@mwallner mwallner mentioned this issue Oct 19, 2020
Merged
9 tasks
@pauby pauby added 2 - Working A user or team member has started working on the issue and removed 0 - _Triaging Issue is accepted, but a milestone has yet to be added for the issue labels Oct 20, 2020
mwallner added a commit to mwallner/boxstarter that referenced this issue Nov 16, 2020
@mwallner
(chocolateyGH-451) StopOnPackageFailiure not stripped without RebootC…
2636a31 
…odes
mwallner added a commit to mwallner/boxstarter that referenced this issue Nov 16, 2020
@mwallner
(chocolateyGH-451) more accurate regex
434cf03
@flcdrg flcdrg mentioned this issue Jan 19, 2021
Closed
@pauby pauby added this to the 2.14.0 milestone Jan 19, 2021
@pauby pauby added 4 - Done Code has been added to the repository, and has been reviewed by a team member and removed 2 - Working A user or team member has started working on the issue labels Jan 19, 2021
pauby added a commit that referenced this issue Jan 19, 2021
@pauby
Merge pull request #452 from mwallner/GH-451
26fd98a 
(GH-451) Fix Boxstarter Package Parameter '-StopOnPackageFailure'
HolisticDeveloper pushed a commit to HolisticDeveloper/boxstarter that referenced this issue Oct 18, 2021
Merge branch 'master' of https://github.com/HolisticDeveloper/boxstarter
5f6559a 


* 'master' of https://github.com/HolisticDeveloper/boxstarter: (58 commits)
  Update chocolatey uninstall url
  Fix chocolatey links
  (chocolateyGH-446) Updates documentation with important info
  (chocolateyGH-443) Adds Windows Explorer item check box view Even though Boxstarter has existing functionality to modify Windows Explorer's settings, the existing functionality did not allow for user's to configure the "Use check boxes to select items" setting.  This commit adds that functionality to the existing set-windowsexploreroptions function.
  (chocolateyGH-451) more accurate regex
  (chocolateyGH-451) StopOnPackageFailiure not stripped without RebootCodes
  (release v2.13.0) Updated version numbers
  chocolateyGH-444 do not pass StopOnPackageFailure to choco
  Merge pull request from GHSA-rpgx-h675-r3jf
  (chocolateyGH-405) Fix package parameter handling (chocolatey#412)
  (chocolateyGH-434) Fix disabling bing search for Win release 2004+ (chocolatey#438)
  chocolateygh-435 docs for DelegateChocoSources
  (build) Replace direct usage of cinst
  (build) Pin all packages to specific version
  (build) Remove deprecated package
  (build) Make project files consistent
  (build) Pin to specific version of nuget.commandline
  (build) Remove VS import for web targets
  (build) Trying to fix AppVeyor build
  (doc) Update template
  ...
@gep13 gep13 modified the milestones: 2.14.0, 3.0.0 Apr 25, 2022
@gep13 gep13 modified the milestones: 3.0.0-beta-20220426-14, 3.0.0 Jul 14, 2022
@gep13 gep13 added 5 - Released The issue has been resolved, and released to the public for consumption and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member labels Jul 14, 2022
@choco-bot
Copy link

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwallner mwallner

Labels
5 - Released The issue has been resolved, and released to the public for consumption Bug Issues where something has happened which was not expected or intended Priority_HIGH Issues that are considered to be a high priority to get fixed
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

(GH-451) Fix Boxstarter Package Parameter '-StopOnPackageFailure' mwallner/boxstarter
4 participants
@gep13 @mwallner @choco-bot @pauby