-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(store): SS Raw Benchmarks #17504
Conversation
BTW, the esasist way for me to setup rocksdb to run the test is:
|
So neat @yihuang! I really need to spend more time playing with nix and getting to know it. Thanks for sharing. I'll use this going forward as it's much easier! |
return pebbledb.New(dataDir) | ||
}, | ||
"btree(sqlite)": func(dataDir string) (store.VersionedDatabase, error) { | ||
"btree_sqlite": func(dataDir string) (store.VersionedDatabase, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we keep the btree prefix to the sqlite, but no lsm prefix to the other dbs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My intention was to indicate that it's not a direct BTree implementation, but rather an existing storage engine that utilizes BTrees under the hood.
I can add the type to all of them if you'd like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean we are just benchmarking sqlite, not btree, and we can't simply benchmark btree without referring to a specific implementation, and there are so many design decisions a db implementation need to make.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just curious about the result
Description
Raw benchmarks, i.e. benchmarks of raw API calls against each SS backend engine.
https://pastebin.com/raw/q5LhTcRy
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change