Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaia master should not be updated to Cosmos-SDK master #425

Closed
2 of 4 tasks
tac0turtle opened this issue Jun 22, 2020 · 9 comments
Closed
2 of 4 tasks

Gaia master should not be updated to Cosmos-SDK master #425

tac0turtle opened this issue Jun 22, 2020 · 9 comments
Assignees

Comments

@tac0turtle
Copy link
Member

tac0turtle commented Jun 22, 2020

Summary

Gaia represents the software used by the Cosmos Hub. Its master branch should not look at the master branch of the Cosmos-SDK as this is unstable software. The reason this is being done is when we moved Gaia out of the Cosmos-SDK we removed the cmd's from the Cosmos-SDK, so we used Gaia as part of the SDK testing suite. We have now brought the cmd's back to the SDK and do not have a need for Gaia to look at master.

Problem Definition

Gaia master branch is looking at the latest Cosmos-SDK master branch.

Proposal

Gaia is pinned to a release of the Cosmos-SDK (0.37.x), it's master branch gets minor updates and can be used on testnets for early-stage testing before being deployed to the hub.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez
Copy link
Contributor

alexanderbez commented Jun 22, 2020

I approve of this. Very easy to do this. Have the latest 2.x.x release of Gaia now be main.

@tac0turtle
Copy link
Member Author

will let this sit for a couple of days before I make the changes

@webmaster128
Copy link
Member

webmaster128 commented Jun 23, 2020

When this is implemented (which makes perfect sense as far as I can see), where would a version of gaia be maintained that contains the latest updates to Cosmos SDK master? Would someone work on this at all? We'd need somthing like a gaia nightly to start testing stargate clients (cosmos/cosmjs#242).

Thank you!

@tac0turtle
Copy link
Member Author

When this is implemented (which makes perfect sense as far as I can see), where would a version of gaia be maintained that contains the latest updates to Cosmos SDK master? Would someone work on this at all? We'd need somthing like a gaia nightly to start testing stargate clients (CosmWasm/cosmjs#242).

Thank you!

could simd & simcli be used from the sdk. WE would just need to add a make target for installing instead of building.

@webmaster128
Copy link
Member

could simd & simcli be used from the sdk. WE would just need to add a make target for installing instead of building.

Yes, I think that would do the trick. Would it be possible to dockerize simd/simcli like https://hub.docker.com/r/tendermint/gaia (I can build and upload locally if needed)? It would need to run as a testing chain on dev machines and CIs without a Go build environment.

@tac0turtle
Copy link
Member Author

Yes, I think that would do the trick. Would it be possible to dockerize simd/simcli like hub.docker.com/r/tendermint/gaia (I can build and upload locally if needed)? It would need to run as a testing chain on dev machines and CIs without a Go build environment.

yes, ill take care of that in the coming days.

@tac0turtle tac0turtle mentioned this issue Jun 24, 2020
11 tasks
@alessio
Copy link
Contributor

alessio commented Jun 24, 2020

I agree with this. This burden is becoming unbearable

@jgimeno
Copy link
Contributor

jgimeno commented Jun 24, 2020

This is music to my ears! I totally agree!

@tac0turtle tac0turtle self-assigned this Jul 1, 2020
@tac0turtle
Copy link
Member Author

default branch is now main and has been reverted to latest release. I will begin migrating things from master that need to be here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants