Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SDK Commit #419

Closed
wants to merge 23 commits into from
Closed

Bump SDK Commit #419

wants to merge 23 commits into from

Conversation

jgimeno
Copy link
Contributor

@jgimeno jgimeno commented Jun 12, 2020

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze
Copy link
Collaborator

@jgimeno avísame si necesitas una mano con esta PR 👍

@tac0turtle
Copy link
Member

❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️

@alexanderbez alexanderbez changed the title Jonathan/upgrade new sdk Bump SDK Commit Jun 12, 2020
@jgimeno
Copy link
Contributor Author

jgimeno commented Jun 18, 2020

I am working on gaia, is not abandoned.

@jgimeno
Copy link
Contributor Author

jgimeno commented Jun 24, 2020

Hey guys, with last cosmos master gaia has a problem, it panics directly, here is the stack so you can see that is something that breaks deep down:

➜  gaia git:(jonathan/upgrade-new-sdk) build/gaiad start
I[2020-06-24|15:14:50.264] starting ABCI with Tendermint                module=main
panic: internal error

goroutine 1 [running]:
github.com/cosmos/cosmos-sdk/x/genutil.DeliverGenTxs(0x562bf40, 0xc00003e638, 0x56448e0, 0xc000f10480, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        github.com/cosmos/[email protected]/x/genutil/gentx.go:109 +0x30d
github.com/cosmos/cosmos-sdk/x/genutil.InitGenesis(...)
        github.com/cosmos/[email protected]/x/genutil/genesis.go:19
github.com/cosmos/cosmos-sdk/x/genutil.AppModule.InitGenesis(0x5626740, 0xc000145b00, 0x5603fc0, 0xc000e9c420, 0xc000181dd0, 0x562bf40, 0xc00003e638, 0x56448e0, 0xc000f10480, 0x0, ...)
        github.com/cosmos/[email protected]/x/genutil/module.go:88 +0x167
github.com/cosmos/cosmos-sdk/types/module.(*Manager).InitGenesis(0xc0000bfd50, 0x562bf40, 0xc00003e638, 0x56448e0, 0xc000f10480, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        github.com/cosmos/[email protected]/types/module/module.go:278 +0x298
github.com/cosmos/gaia/app.(*GaiaApp).InitChainer(0xc0001a5800, 0x562bf40, 0xc00003e638, 0x56448e0, 0xc000f10480, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        github.com/cosmos/gaia/app/app.go:412 +0x138
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).InitChain(0xc000eaa640, 0x2ae85c18, 0xed6854562, 0x0, 0xc000245ad8, 0x7, 0xc000f103c0, 0x613c108, 0x0, 0x0, ...)
        github.com/cosmos/[email protected]/baseapp/abci.go:41 +0x2ad
github.com/tendermint/tendermint/abci/client.(*localClient).InitChainSync(0xc0010024e0, 0x2ae85c18, 0xed6854562, 0x0, 0xc000245ad8, 0x7, 0xc000f103c0, 0x613c108, 0x0, 0x0, ...)
        github.com/tendermint/[email protected]/abci/client/local_client.go:223 +0xf8
github.com/tendermint/tendermint/proxy.(*appConnConsensus).InitChainSync(0xc000181010, 0x2ae85c18, 0xed6854562, 0x0, 0xc000245ad8, 0x7, 0xc000f103c0, 0x613c108, 0x0, 0x0, ...)
        github.com/tendermint/[email protected]/proxy/app_conn.go:65 +0x6b
github.com/tendermint/tendermint/consensus.(*Handshaker).ReplayBlocks(0xc000dae8e8, 0xa, 0x0, 0xc000561fb0, 0x6, 0xc00003e160, 0x7, 0x0, 0x0, 0x0, ...)
        github.com/tendermint/[email protected]/consensus/replay.go:319 +0x69b
github.com/tendermint/tendermint/consensus.(*Handshaker).Handshake(0xc000dae8e8, 0x56488e0, 0xc000144600, 0x80, 0x4fa5ac0)
        github.com/tendermint/[email protected]/consensus/replay.go:269 +0x485
github.com/tendermint/tendermint/node.doHandshake(0x5647ae0, 0xc0000102c8, 0xa, 0x0, 0xc000561fb0, 0x6, 0xc00003e160, 0x7, 0x0, 0x0, ...)
        github.com/tendermint/[email protected]/node/node.go:264 +0x19a
github.com/tendermint/tendermint/node.NewNode(0xc000eaa8c0, 0x5624dc0, 0xc0001b3040, 0xc0004105e0, 0x56025c0, 0xc000e9b020, 0xc0004106f0, 0x53a2ef0, 0xc000410c20, 0x562ca00, ...)
        github.com/tendermint/[email protected]/node/node.go:587 +0x343
github.com/cosmos/cosmos-sdk/server.startInProcess(0xc000e9ad60, 0x562c100, 0xc0000111d0, 0x53a4508, 0x0, 0x0)
        github.com/cosmos/[email protected]/server/start.go:184 +0x4f3
github.com/cosmos/cosmos-sdk/server.StartCmd.func2(0xc000ebfb80, 0x613c108, 0x0, 0x0, 0x0, 0x0)
        github.com/cosmos/[email protected]/server/start.go:86 +0xde
github.com/spf13/cobra.(*Command).execute(0xc000ebfb80, 0x613c108, 0x0, 0x0, 0xc000ebfb80, 0x613c108)
        github.com/spf13/[email protected]/command.go:842 +0x453
github.com/spf13/cobra.(*Command).ExecuteC(0xc00019e000, 0x51b6e23, 0xc000dafe20, 0x4744db2)
        github.com/spf13/[email protected]/command.go:950 +0x349
github.com/spf13/cobra.(*Command).Execute(...)
        github.com/spf13/[email protected]/command.go:887
github.com/tendermint/tendermint/libs/cli.Executor.Execute(0xc00019e000, 0x53a4950, 0x5195aa3, 0x10)
        github.com/tendermint/[email protected]/libs/cli/setup.go:89 +0x3c
main.main()
        github.com/cosmos/gaia/cmd/gaiad/main.go:71 +0x7ea
➜  gaia git:(jonathan/upgrade-new-sdk)

@alessio @marbar3778 @alexanderbez @fedekunze

@tac0turtle
Copy link
Member

Hey before more time is spent in this PR I would recommend reading #425 and commenting if you disagree

@jgimeno
Copy link
Contributor Author

jgimeno commented Jun 24, 2020

Thanks @marbar3778 !

@tac0turtle
Copy link
Member

closing this in favor of #425

@tac0turtle tac0turtle closed this Jul 1, 2020
@tac0turtle tac0turtle deleted the jonathan/upgrade-new-sdk branch July 6, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants