Ensure "cascade" mapping is set for ResolveTargetDocumentListener

[jaymecd]

... due 'cascade' was not accessible in ResolveTargetDocumentListener while remapping and resolved target document does not inherit original cascade rules.

[malarzm]

Few tests are failing now and are relevant to your PR

[jaymecd]

Tnx, my bad, was too fast to create PR, fix it soon

[jaymecd]

Still having 1 error (looks like unrelared):

1) Doctrine\ODM\MongoDB\Tests\Functional\ReferencesTest::testReferenceOneWithNullId
Failed asserting that exception of type "Doctrine\Common\Proxy\Exception\OutOfBoundsException" matches expected exception "\Doctrine\ODM\MongoDB\DocumentNotFoundException". 
Message was: "Missing value for primary key profileId on Documents\Profile"

Any idea how to fix?

[jaymecd]

Btw, this error appears on master as well.

[jaymecd]

fyi @jmikola

[jaymecd]

Blocked by #890

[jmikola]

@jaymecd: #890 is fixed by #900. See the latter PR for more info.

Feel free to rebase and ping me to review.

[jaymecd]

@jmikola, done

[jmikola]

I realize this makes the ODM handling in line with ORM (see: here), but can you elaborate on the bug that this fixes? From the test changes, it looks like the referenced document associations never received cascade info.

[jmikola]

Other than expectations in tests, I don't see isCascadeCallbacks used anywhere in ODM. ORM has no such cascade, either. @jwage: is this obsolete and a candidate for removal?

[jaymecd]

@jmikola, yes similar processing as ORM has, but I'm afraid that didn't get you correctly what u want me to do. check for valid enum?

In general, internal logic is based on isCascade* properties of mapping and it works fine.

Property cascade is required only by ResolveTargetDocumentListener to keep tracking input cascade option for remapping, as ClassMetadataInfo::mapField() expects only cascade, but not isCascade*. And it exists only if cascade was explicitly set.

[jmikola]

@jaymecd: You last comment explained it. It wasn't clear to me from the original PR message what the change accomplished, but I see what you're referring to about the cascade property now. Thanks!

[jmikola]

Merged in a6bd9a8 with some amending to the commit message.

[jaymecd]

Welcome and thank you too.