Fix ReferencesTest failure with Doctrine Common 2.4.2 #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was originally added alongside a ReferenceMany test in d1b0ed3, but the latter was removed in a2c3ddd when @jwage added tests for non-scalar identifiers. The ReferenceOne test likely should have been removed at that point, too. This fixes a build failure with Doctrine Common 2.4.2, due to doctrine/common#298. Therein, the common proxy classes no longer allow for null identifiers, even though they are technically valid in MongoDB.
jmikola
added a commit
that referenced
this pull request
Jun 5, 2014
Fix ReferencesTest failure with Doctrine Common 2.4.2
This was referenced Jun 5, 2014
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of build 1236, the test suite was failing due to doctrine/common#298, which was included in Doctrine Common v2.4.2.