Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[syncer] fix syncer timeout #319

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

0xcb9ff9
Copy link

Description

  • GetBlocks exists duplicate timeout context, remove it
  • bulkSyncWithPeer re-select peer

Changes include

  • Bugfix (non-breaking change that solves an issue)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels

Testing

  • I have tested this code with the official test suite

@0xcb9ff9 0xcb9ff9 added the bug fix Functionality that fixes a bug label Mar 10, 2023
@0xcb9ff9 0xcb9ff9 self-assigned this Mar 10, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #319 (c3e135b) into dev (d7c5a9e) will decrease coverage by 0.02%.
The diff coverage is 58.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev     #319      +/-   ##
==========================================
- Coverage   47.74%   47.72%   -0.02%     
==========================================
  Files         132      132              
  Lines       20125    20102      -23     
==========================================
- Hits         9608     9594      -14     
+ Misses       9684     9676       -8     
+ Partials      833      832       -1     
Impacted Files Coverage Δ
protocol/client.go 48.61% <ø> (-0.61%) ⬇️
protocol/syncer.go 48.50% <58.00%> (-1.11%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@0xcb9ff9
Copy link
Author

0xcb9ff9 commented Mar 11, 2023

PR #320 replace this

@0xcb9ff9 0xcb9ff9 closed this Mar 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2023
@0xcb9ff9 0xcb9ff9 deleted the fix/syncer-timeout branch March 11, 2023 02:10
@0xcb9ff9 0xcb9ff9 restored the fix/syncer-timeout branch March 11, 2023 07:59
@0xcb9ff9 0xcb9ff9 reopened this Mar 11, 2023
Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please give more manual testing on this?
No confident with the changing impact on syncing stability.

Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DarianShawn DarianShawn merged commit 931da47 into dogechain-lab:dev Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants