-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[syncer] fix syncer timeout #319
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## dev #319 +/- ##
==========================================
- Coverage 47.74% 47.72% -0.02%
==========================================
Files 132 132
Lines 20125 20102 -23
==========================================
- Hits 9608 9594 -14
+ Misses 9684 9676 -8
+ Partials 833 832 -1
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please give more manual testing on this?
No confident with the changing impact on syncing stability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
GetBlocks
exists duplicate timeout context, remove itbulkSyncWithPeer
re-select peerChanges include
Checklist
Testing