-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: [ibft] Fix validator panic due to repeat notification in syncing #320
WIP: [ibft] Fix validator panic due to repeat notification in syncing #320
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## dev #320 +/- ##
==========================================
+ Coverage 47.74% 48.02% +0.28%
==========================================
Files 132 132
Lines 20125 20103 -22
==========================================
+ Hits 9608 9655 +47
+ Misses 9684 9620 -64
+ Partials 833 828 -5
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Tests pass, but manual tests fail when shutting down one of the 4 validator. |
Description
The validators will panic after syncing a bulk of blocks, due to incorrectly implementation of IBFT consensus context handling.
The consensus routine will be triggered multiple times even it is not thread-safe, and occasionally, the built block is clear before gossip it, then the server panic with nil object access.
The PR:
Changes include
Testing