Update Publishing to IIS #1270
Update Publishing to IIS #1270
Conversation
Fix sensitive files language and add VC++ redist troubleshooting issue.
|
Hi @guardrex, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
| @@ -126,7 +132,7 @@ Troubleshooting: | |||
|
|
|||
| - If your application uses the `.UseUrls(...)` extension on `WebHostBuilder`, make sure you have positioned the `.UseUrls(...)` extension before the `.UseIISIntegration()` extension on `WebHostBuilder`. `.UseIISIntegration()` must overwrite any values you provide in `.UseUrls(...)` in order for the reverse-proxy to succeed. | |||
|
|
|||
| Issue #2 | |||
| Issue #3 | |||
There was a problem hiding this comment.
Can we replace all the #'s with a title - for example
Issue Browser no response?
There was a problem hiding this comment.
@danroth27 added those. I'll certainly give it go if he's good with it.
There was a problem hiding this comment.
Yeah, at the time the issues were a single combined bulleted list, which didn't render very well. Also each issue needs it's own linkable subheading so that they can be referenced. Unfortunately I didn't have time to come up with subheading text before the RC2 release needed to go out. @guardrex If you could help out with subheading text that would be great.
There was a problem hiding this comment.
Sure thing ... np. I'll get on it this evening.
There was a problem hiding this comment.
Dah! 😠 Fighting with custom logging this evening. I'll get back on this in the morning.
There was a problem hiding this comment.
@Rick-Anderson @danroth27 I just got back to this. I'm having trouble. It's tough to title these ... There's too much info to title them easily when they don't have short behaviors and/or short possible cause lists.
Giving each a title based on browser response alone doesn't separate them. To give them titles based on all three behavioral classifications (browser response, ANCM log, and Application log) would make the titles too long. Giving them titles based on the possible causes ... also lists of possible causes in some cases ... also makes them too long.
This is why in the original doc I formatted them as three bulleted items to match the behavior followed by indented bullets for the possible causes. I thought that that was the simplest way to run down groups of three behaviors for the dev to match.
We could remove the "Issue #" from each and use a horizontal rule to separate them.
There was a problem hiding this comment.
remove the "Issue #"
Yes, do that.
|
merged - it's taking some time to show up tho. |
|
@Rick-Anderson Is this one ok? It looks like it's closed without being merged. |
|
Hi @guardrex, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
|
Let me know if it needs more work on the layout (e.g., go for |
|
@danroth27 I merged it - see https://github.com/aspnet/Docs/commits/master |
|
@Rick-Anderson please include the commit hash in the PR before closing so that we can verify that things have been merged. No need to reopen anything if the commits on master can be accounted for. |
|
Also, we were having build issues for a couple of days. This has been fixed, so changes should start showing up again. |
|
Thanks! b5194e7 |
|
@guardrex And yes, the formatting still bugs me 😄. Also, now there is no way to link to individual issues, which I think would be useful. |
|
@danroth27 Yep. The troubleshooting of one common error runs into the behaviors of the next. The only problem with titling them was the 500.19 and one of the 502.3 issues, where there are multiple causes. Let me see what happens when I try to title them. I'll give that a shot and create a PR with some proposed titling that might work. |
Fixes #1264