-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Publishing to IIS #1270
Closed
Closed
Update Publishing to IIS #1270
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we replace all the #'s with a title - for example
Issue Browser no response?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danroth27 added those. I'll certainly give it go if he's good with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, at the time the issues were a single combined bulleted list, which didn't render very well. Also each issue needs it's own linkable subheading so that they can be referenced. Unfortunately I didn't have time to come up with subheading text before the RC2 release needed to go out. @guardrex If you could help out with subheading text that would be great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing ... np. I'll get on it this evening.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dah! 😠 Fighting with custom logging this evening. I'll get back on this in the morning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rick-Anderson @danroth27 I just got back to this. I'm having trouble. It's tough to title these ... There's too much info to title them easily when they don't have short behaviors and/or short possible cause lists.
Giving each a title based on browser response alone doesn't separate them. To give them titles based on all three behavioral classifications (browser response, ANCM log, and Application log) would make the titles too long. Giving them titles based on the possible causes ... also lists of possible causes in some cases ... also makes them too long.
This is why in the original doc I formatted them as three bulleted items to match the behavior followed by indented bullets for the possible causes. I thought that that was the simplest way to run down groups of three behaviors for the dev to match.
We could remove the "Issue #" from each and use a horizontal rule to separate them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, do that.