Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breaking changes docs #34063

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

BillWagner
Copy link
Member

@BillWagner BillWagner commented Nov 7, 2024

Fixes #33996

Add the configuration and TOC changes for publishing the breaking changes articles to the razor compiler.


Internal previews

📄 File 🔗 Preview link
aspnetcore/toc.yml aspnetcore/toc

Fixes dotnet#33996

Add the configuration and TOC changes for publishing the breaking changes articles to the razor compiler.
@BillWagner BillWagner force-pushed the add-razor-breaking-changes branch from 62acfbf to f6bb61b Compare November 8, 2024 21:58
BillWagner added a commit to BillWagner/razor that referenced this pull request Nov 12, 2024
Add the required learn metadata to publish these articles on learn.

See dotnet/AspNetCore.Docs#34063
The file based meta data isn't working with this folder layout. So, add the metadata to the files directly

See dotnet/razor#11199
@BillWagner
Copy link
Member Author

Once dotnet/razor#11199 is merged, this should be fine.

@BillWagner BillWagner marked this pull request as ready for review November 12, 2024 14:50
333fred pushed a commit to dotnet/razor that referenced this pull request Nov 12, 2024
* Add metadata

Add the required learn metadata to publish these articles on learn.

See dotnet/AspNetCore.Docs#34063

* add the date.
@BillWagner
Copy link
Member Author

trying a fresh build

@BillWagner BillWagner closed this Nov 12, 2024
@BillWagner BillWagner reopened this Nov 12, 2024
@BillWagner BillWagner closed this Nov 12, 2024
@BillWagner BillWagner reopened this Nov 12, 2024
@BillWagner BillWagner closed this Nov 12, 2024
@BillWagner BillWagner reopened this Nov 12, 2024
@BillWagner BillWagner merged commit de099b7 into dotnet:main Nov 12, 2024
3 of 6 checks passed
@BillWagner BillWagner deleted the add-razor-breaking-changes branch November 12, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the dependent repo and article for breaking changes in the razor compiler
2 participants