Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata #11199

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Add metadata #11199

merged 2 commits into from
Nov 12, 2024

Conversation

BillWagner
Copy link
Member

Add the required learn metadata to publish these articles on learn.

See dotnet/AspNetCore.Docs#34063

Add the required learn metadata to publish these articles on learn.

See dotnet/AspNetCore.Docs#34063
@BillWagner
Copy link
Member Author

@333fred PTAL and merge if you approve.

BillWagner added a commit to BillWagner/AspNetCore.Docs that referenced this pull request Nov 12, 2024
The file based meta data isn't working with this folder layout. So, add the metadata to the files directly

See dotnet/razor#11199
Copy link
Member

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change seems fine, assuming the metadata is correct. @333fred: Do you want to take a look and merge?

@333fred 333fred merged commit a9f72d5 into dotnet:main Nov 12, 2024
12 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 12, 2024
@BillWagner BillWagner deleted the add-metadata branch November 12, 2024 18:22
BillWagner added a commit to dotnet/AspNetCore.Docs that referenced this pull request Nov 12, 2024
* Add breaking changes docs

Fixes #33996

Add the configuration and TOC changes for publishing the breaking changes articles to the razor compiler.

* Remove non-functioning attributes

The file based meta data isn't working with this folder layout. So, add the metadata to the files directly

See dotnet/razor#11199
@jjonescz jjonescz modified the milestones: Next, 17.13 P2 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants