-
-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task add style cope and fxcop analyzers #1258
Task add style cope and fxcop analyzers #1258
Conversation
…to task-add-style-cope-and-fxcop-analyzers
…to task-add-style-cope-and-fxcop-analyzers
Wojciech how many warnings do you get when you perform a clean build of the solution with all these rules enabled? |
There is a lot of SA1000 https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1000.md If you decide to clean the code, I can make one bulk PR for simple rules in no time. |
@AndreyAkinshin I like the concept of having some static code analysis, are you ok with adding StyleCop and FxCop? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Is there any update on this topic? Should I improve something? |
@AndreyAkinshin ping |
1 similar comment
@AndreyAkinshin ping |
@WojciechNagorski thanks! |
@WojciechNagorski it seems that one of our integration tests ( |
Ok no problem. I will take a look tomorrow. |
In this PR I added StyleCop and FxCop packages for every project in the solution.
In
CodingStyle.ruleset
file you can find configuration based ondotnet/corefx
repo: https://github.com/dotnet/corefx/blob/06007cdedee9cfb096d884016a99e3a64bdccb45/src/Common/src/CoreLib/CodeAnalysis.rulesetI've removed some line. Please validate this list before merge.
There you can find similar
props
file fromdotnet/corefx
: https://github.com/dotnet/corefx/blob/3d37c15b43be2a36de5dc7f9076584407b430175/eng/Analyzers.propsPR for Hacktoberfest 😄