Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task remove trailing whitespace #1259

Merged

Conversation

WojciechNagorski
Copy link
Contributor

In this PR I remove all trailing whitespace in the solution.
There is a documentation for this StyleCop rule: https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1028.md

I will understand if this PR is rejected.

PR for Hacktoberfest 😄

@adamsitnik
Copy link
Member

Are you sure that you want to be on a git blame for every line in the project? ;P

@AndreyAkinshin what do you think?

@WojciechNagorski
Copy link
Contributor Author

Only
image

I am aware of the problems: Incorrect blame, merge in PRs.
If this PR is rejected, I can disable SA1028 rule.

@AndreyAkinshin
Copy link
Member

LGTM.
@wojtpl2 could you please resolve the conflicts with the master branch?

@WojciechNagorski
Copy link
Contributor Author

I've resolved the conflicts. And I removed additional trailing whitespaces.

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks again!

@adamsitnik adamsitnik merged commit 2ba3033 into dotnet:master Oct 1, 2019
@AndreyAkinshin AndreyAkinshin added this to the v0.11.6 milestone Oct 1, 2019
@WojciechNagorski WojciechNagorski deleted the task-remove-trailing-whitespace branch October 1, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants