Fix down-level SSL/TLS version warnings #3126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/ConnectionTestParametersData.cs
Outdated
Show resolved
Hide resolved
paulmedynski
requested changes
Jan 21, 2025
|
Thanks - I've made that correction. |
benrr101
approved these changes
Jan 21, 2025
| @@ -79,9 +81,9 @@ public static TestTdsServer StartServerWithQueryEngine(QueryEngine engine, bool | |||
|
|
|||
| public static TestTdsServer StartTestServer(bool enableFedAuth = false, bool enableLog = false, | |||
| int connectionTimeout = DefaultConnectionTimeout, [CallerMemberName] string methodName = "", | |||
| X509Certificate2 encryptionCertificate = null, TDSPreLoginTokenEncryptionType encryptionType = TDSPreLoginTokenEncryptionType.NotSupported) | |||
| X509Certificate2 encryptionCertificate = null, SslProtocols encryptionProtocols = SslProtocols.Tls12, TDSPreLoginTokenEncryptionType encryptionType = TDSPreLoginTokenEncryptionType.NotSupported) | |||
There was a problem hiding this comment.
nit: if the arguments have to go on multiple lines, it should be one argument per line.
There was a problem hiding this comment.
but I definitely won't hold the review on this.
There was a problem hiding this comment.
Yeah it's the existing "style", so it gets a pass for a targeted change like this.
paulmedynski
approved these changes
Jan 21, 2025
samsharma2700
approved these changes
Jan 21, 2025
benrr101
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Added test for downlevel connectivity warning * Correctly test bit flags for legacy SSL protocol warning * Corrected warning disablement/restore. (cherry picked from commit 198b906)
benrr101
added a commit
that referenced
this pull request
Jan 22, 2025
* Fix down-level SSL/TLS version warnings (#3126) * Added test for downlevel connectivity warning * Correctly test bit flags for legacy SSL protocol warning * Corrected warning disablement/restore. (cherry picked from commit 198b906) * Test by rolling back changes to connection test matrix --------- Co-authored-by: Edward Neal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3120. I'll backport this to 6.0 if this is merged.
To verify this, I've expanded our test TDS server, adding support for using a named SSL protocol. It adds to the data for
CertificateTestWithTdsServer.BeginWindowsConnectionTestandBeginLinuxConnectionTest, including an end-to-end connection test to a TDS server which only supports TLS 1.0 & 1.1.